Hi Xiao,
After a quick look at your webrev, below are a few comments:
1. In Makefile.sfw, hard-coding of program name and version can be
avoided and this info can be picked up from METADATA, something like:
VER = $(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh)
In install-sg3 script remove the hardcoding of VERS since that is
passed from the Makefile.sfw.
2. Per Jim Walker, do not use "pragma ident" keywords in files other
than source files. In Makefiles, install scripts and such, use "ident"
(without "pragma").
3. Change 'env ' to 'env - ' in Makefile.sfw.
4. In install-sg3 it is recommended to use /usr/bin/ksh93 instead of
/bin/sh. This allows you to add:
# stop at first error
set -o errexit
And to call "source" instead of "." in this line:
source ${SRC}/tools/install.subr
Regards
Muktha
xiao li - Sun Microsystems - Beijing China wrote:
> Hi Experts,
> I'm responsible for integrating sg3 utilities into opensolaris.
> My code change is available at:
> http://cr.opensolaris.org/~xl222276/sg3utils
>
> You comments will be highly appreciated.
>
> Thanks and regards,
> -Xiao
>
>
>
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
>
