xiao li - Sun Microsystems - Beijing China wrote:
> Hi Paul,
> Please see below.
>
> Paul Cunningham wrote:
>> Xiao,
>>
>> Its looking good, I just noticed something else though ....
>>
>>
>> xiao li - Sun Microsystems - Beijing China wrote:
>>> Paul Cunningham wrote:
>>>> xiao li - Sun Microsystems - Beijing China wrote:
>>>>>
>>>>> updated webrev:
>>>>> http://cr.opensolaris.org/~xl222276/sg3utils/
>> ... cut ...
>>>>
>>>> 4. usr/src/pkgdefs/SUNWsg3utilsr/copyright
>>>> & usr/src/pkgdefs/SUNWsg3utilsu/copyright
>>>> Do you need to put the full licence in here ? (I prefer
>>>> it as it is though)
>>> I saw that a lot of other packages are doing things this way, should
>>> I keep it like them?
>>
>> Check within Sun
>>
>> ... cut ...
>>
>>>> 6. usr/src/pkgdefs/SUNWsg3utilsu/depend
>>>> Have you checked you have no other dependencies using
>>>> the dependency checker script?
>>> Yes, I've checked using "make check_deps" and modified the depend file.
>>
>> I just noticed you have ...
>> 54 P SUNWgccruntime GCC Runtime libraries
>> in your depend file, but in your Makefile.sfw you tell it to build
>> with the Sun compiler - so do you need this gcc runtime pkg?
> I'm using $(GCC) and $(GMAKE) for building, and I got this depend by
> using "make check_deps".
> So I think it is right.
so why in Makefile.sfw ...
45 CC=$(CC) \
which is the Sun compiler;
maybe in there you should explicitly define CC=, on rules 'all:' and
'$(VER)/config.status:' to $(GCC) from Makefile.master.
But having said that, I think if you can get it to build with the Sun
compiler you should really be using that.
Paul
--
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Business Unit
