See below ...
Paul Cunningham wrote:
> Darren,
>
> See comments below from my quick skip through ...
>
> Paul
>
> Darren J Moffat wrote:
>> http://cr.opensolaris.org/~darrenm/libmcrypt/webrev/
>>
>> What other things do I need to do ? I'm sure there is more ?
>
> ==== Start of Comments ====
>
> 1. usr/src/lib/libmcrypt/Makefile.sfw
> Change the options on '.configure' to use those
> predefined in the Makefile.master file, eg. using
> something like '.configure $(CONFIGURE_OPTIONS)'.
> See other recent pkg integrations for examples.
>
> Do you need to explicitly define bindir, includedir,
> etc. when is taken care of by --prefix define?
>
> After running 'make install' is there stuff you need
> to remove from the proto area that are not delivered
> so the build checks don't fail.
>
> Why does this not show up as just "New" like
> the other new files?
>
> 2. usr/src/lib/libmcrypt/install-sfw
> & usr/src/lib/libmcrypt/install-sfw-64
> Why is the an 'exit 0' half way through this?
>
> 3. usr/src/lib/Makefile
> & usr/src/pkgdefs/Makefile
> These need resyncing with the gate so it doesn't
> look in the webrev as though you are trying to
> delete other stuff!
>
> 4. usr/src/pkgdefs/SUNWlibmcrypt/depend
> This looks like the default depend! Have you
> run the dependency checking script against your
> pkg. If it doesn't have any others just put
> ' DATAFILE= depend' in the Makefile and then
> remove this file so it uses the default one.
>
> If you keep this file move the 'Copyright' lines
> down to after the 'CDDL HEADER END' header.
>
> 5. usr/src/pkgdefs/SUNWlibmcrypt/pkginfo
> You don't need to checkin this file its generated from
> the pkginfo.tmpl file. So remove this.
>
> 6. usr/src/pkgdefs/SUNWlibmcrypt/prototype_com
> & usr/src/pkgdefs/SUNWlibmcrypt/prototype_i386
> Remove the commented out '#f ..' line
>
> 7. man pages
> You need to add the Sun stuff at the end. See other
> pkgs for how that is done.
8. METADATA
Your package needs a METADATA file. See other packages
for examples
> ==== End of Comments ======
>
--
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Computer Products
