Darren J Moffat wrote:
>
> http://cr.opensolaris.org/~darrenm/libmcrypt/webrev/
>
> What other things do I need to do ? I'm sure there is more ?
1. AFAIK these things may be nice (most of these item are very generic
things which are "usual suspects" for build problems in the tree):
- Plese use "env - ..." and not "env ..." in the Makefiles to make sure
"configure"&&"make" only see the env variables they should really get
(and not pick-up any random env variable)
- Please use either $(SHELL) or /usr/bin/bash for "configure" calls (so
we know which one is used and "configure" doesn't pick one itself)
- Please use /usr/bin/ksh93 or /usr/bin/bash for install-sfw* and add a
$ set -o xtrace # at the beginning and replace ".
${SRC}/tools/install.subr" with "source ${SRC}/tools/install.subr" (the
idea is to catch failures in the script and abort it at that point,
right now the script will just continue)
2. Non-generic things:
- install-sfw*: AFAIK this is only for debugging, right ?
-- snip --
+echo `pwd`
+exit 0
-- snip --
----
Bye,
Roland
--
__ . . __
(o.\ \/ /.o) roland.mainz at nrubsig.org
\__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer
/O /==\ O\ TEL +49 641 3992797
(;O/ \/ \O;)
