Chris, Here are some comments, see below ...
Paul Christopher Mi wrote: > > Please help review this webrev. > > URL: > http://cr.opensolaris.org/~mishuang/gnu-gperf/ > > CR: > 6649409 GNU gperf to be included into SFW consolidation > > PSARC case: > http://opensolaris.org/os/community/arc/caselog/2008/123/ > > Any comments are appreciated. =========== Start of Comments ============= 1. usr/src/cmd/gnu-gperf/METADATA Shouldn't this have info in it about; package version, where it comes from, etc. 2. usr/src/cmd/gnu-gperf/Makefile.sfw Have you thought about using 'make install' instead of 'install-sfw' ? 3. usr/src/cmd/gnu-gperf/install-sfw Should the dir created by 'mkdir -p ..' be in 'Targetdirs' instead? 4. usr/src/pkgdefs/SUNWgnu-gperf/depend Is this different to the default 'depend' file, if not shouldn't you be using that? =========== End of Comments =============== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
