Chris, Christopher Mi wrote: > > Thanks very much for your comments. > Here are my replies, see below ... > > I have update the webrev at, > http://cr.opensolaris.org/~mishuang/gnu-gperf/
Looks okay to me now (including the updated SUNWgnu-gperf/Makefile). Re, your reply ... > I think install-sfw not only 'make install', but does other things, > e.g. process the man page. And I'm not say you should do it that way (as I prefer the 'install-sfw' way), but if you look in Danek's webrev you can see how he handled the install & 'man page' stuff ... http://cr.opensolaris.org/~dduvall/sfw-nethack/usr/src/cmd/nethack/Makefile.sfw.html Paul > > Paul Cunningham wrote: > >> Here are some comments, see below ... >> >> Paul >> >> Christopher Mi wrote: >> >> >>> Please help review this webrev. >>> >>> URL: >>> http://cr.opensolaris.org/~mishuang/gnu-gperf/ >>> >>> CR: >>> 6649409 GNU gperf to be included into SFW consolidation >>> >>> PSARC case: >>> http://opensolaris.org/os/community/arc/caselog/2008/123/ >>> >>> Any comments are appreciated. >>> >> >> >> =========== Start of Comments ============= >> >> 1. usr/src/cmd/gnu-gperf/METADATA >> Shouldn't this have info in it about; package version, where >> it comes from, etc. >> > > Yes, it should include more information. I have updated this file. > >> 2. usr/src/cmd/gnu-gperf/Makefile.sfw >> Have you thought about using 'make install' instead of >> 'install-sfw' ? >> > > I think install-sfw not only 'make install', but does other things, > e.g. process the man page. > >> 3. usr/src/cmd/gnu-gperf/install-sfw >> Should the dir created by 'mkdir -p ..' be in 'Targetdirs' >> instead? >> > > I didn't notice the 'Targetdirs' before and it seems that this file > should help me to make the dir. I have updated this file. > >> 4. usr/src/pkgdefs/SUNWgnu-gperf/depend >> Is this different to the default 'depend' file, if not >> shouldn't you be using that? >> > > Yes, I should use the default one. I have deleted this file. > >> =========== End of Comments =============== >> >> -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products General Dynamics Itronix Europe Ltd. Pioneer House Chivers Way Histon, Cambridgeshire, UK, CB24 9NL Ph: +44 (0)1223 200648 FAX: +44 870 4324162 Email: paul.cunningham at tadpole.com This email message is for the sole use of the intended recipient(s) and may contain GDC4S confidential or privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not an intended recipient, please contact the sender by reply email and destroy all copies of the original message
