Danek, Mainly looks okay to me, just some minor comments, see below ...
Paul Danek Duvall wrote: > http://cr.opensolaris.org/~dduvall/sfw-nethack/ > > I think this is pretty straightforward. I'll ping individuals tomorrow if > I don't get a response. :) ==== Start of Comments ================== 1. usr/src/cmd/nethack/METADATA Out of interest, what is the OSR ? 2. usr/src/pkgdefs/SUNWnethack/pkginfo.tmpl + usr/src/pkgdefs/SUNWnethackr/pkginfo.tmpl There used to be a reason why the "DESC=" line had the package's version on it (I forget why) - you and others haven't included it. But other new and modified packages are still including it (in various inconsistent forms). So shouldn't this be consistent across all sfw packages? 3. usr/src/pkgdefs/SUNWnethackr Should this SUNW package use the same 'copyright' (file) as SUNWnethack? ==== End of Comments ==================== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
