Hi Charles, I have some comments that I got in gnu-mc project. In Makefile.sfw, 1) It's better to use $(CCSMAKE) instead of hard-coded path.
2) It's better to set PATH to $(SFW_PATH) so that build does not accidentally use some tool from the "outside". 3) It's better to use libraries from $(ROOT) rather than /. I mean, LD_OPTIONS should have -L$(ROOT)/usr/lib Here's the link to gnu-mc's Makefile.sfw for your reference, http://cr.opensolaris.org/~reedarx/sfwnv-mc/usr/src/cmd/mc/Makefile.sfw.html Thanks, Reed Charles Baker wrote: > Hi, > > A code review for the proposed inclusion of axyftp into the > sfw consolidation has been posted to: > > http://cr.opensolaris.org/~cebaker/axyftp-6674220/ > > Thanks in advance for your timely comments. > > Charles
