Charles, Here are a few minor comments, see below ...
Paul Charles Baker wrote: > Hi, > > A code review for the proposed inclusion of axyftp into the > sfw consolidation has been posted to: > > http://cr.opensolaris.org/~cebaker/axyftp-6674220/ ==== Start of Comments ================================= 1. usr/src/cmd/axyftp/METADATA This doesn't include the Sun "PACKAGE:" name field 2. usr/src/cmd/axyftp/install-axyftp I don't think it's normal to create directories here, its normally done by putting them in the 'Targetdirs' file. 3. usr/src/cmd/axyftp/sunman-stability Is "Interface Stability Alpha" correct? ie. is Alpha a valid Sun stablility level. 4. usr/src/pkgdefs/SUNW*/copyright I give up commenting on the *length* of these copyright message files :-) (ignore me) But should it have "The End" at the end of the file? 5. usr/src/pkgdefs/SUNWaxyftp/depend The Sun copyright message should probably be after "CDDL HEADER END" header ==== End of Comments =================================== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
