Raymond, Mainly looks good to me from my quick review. See minor comments below ...
Paul Raymond Xiong wrote: > Can anyone help to review my code for Erlang/OTP integration? > > http://cr.opensolaris.org/~rayx/erlang/webrev/ > > Here is its ARC material: > > > http://opensolaris.org/os/community/arc/caselog/2008/210/materials/final-spec-txt/ > > The code is based on Rahul's original code for CCD integration, > but I made some changes(Rahul and Jim has kindly reviewed some > of those changes). > > Note: I knew of Targetdirs usage from recent discussion on this > alias, and I have changed my code to use it. But I just use > Targetdirs to create top-level directories and doesn' list all > of subdirs(because there are too many), I suppose that's OK. > === Start of Comments ========= 1. usr/src/cmd/erlang/Makefile.sfw Could you have used the a default --prefix and --mandir are set in Makefile.master ? See comment in http://cr.opensolaris.org/~jacobs/2008-03-21-sfwnv-cups/usr/src/cmd/cups/Makefile.sfw.html 2. usr/src/pkgdefs/SUNWerlang-doc/depend Does this really depend on SUNWerlang? After all its only documentation which you could have installed without the binary stuff! (Just a thought) 3. usr/src/cmd/erlang/postinstall-sfw Saw your comment above - but I would say the dirs should be in Targetdirs. 4. usr/src/pkgdefs/SUNW*/copyright Just my normal comment about the length of the 'copyright' files :-( Have noticed lately, in reviews, that some people are using the short version. (Ignore if you so wish) === End of Comments =========== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
