Raymond Xiong wrote:
> What I mean is, the coding style of cups Makefile.sfw is quite
> different from most other exising applications on SFW gate. I
> can see the benefit of its apporach, but I am not sure what's
> the recommended way(since most others don't use that way). I
> wonder if we have a guideline for those details?
The main guideline is to keep it simple and think of the folks
that might come work on it later (don't use every whizzy Makefile
trick you find :)
Beyond that what you're seeing is a lot of history. Norm, I believe,
is trying to come up with ways of making integrating things easier,
and since he generally works on the printing stuff you're going
to see it appear there first. And no, most others don't use it
since cups just appeared and they predate it :)
I would say check it out and if it seems easier copy it. If you
have questions ask here or perhaps ask Norm nicely. Evolution
is ok, it is just slow.
> My question is: should I list all of them in Targetdirs(I doubt
> it) or is it OK to just add the following(currently I only add
> /usr/share/doc/erlang, the top-level dir, in Targetdirs):
You can list all of them or none of them or some of them. It depends.
>
> /usr/share/doc/erlang
> |- /usr/share/doc/erlang/doc
> |- /usr/share/doc/erlang/erts-5.6.1
> +- /usr/share/doc/erlang/lib
>
> Note that while I don't define those subdirs in Targetdirs, I
> don't create them explicitly in postinstall.ksh. Instead, they
> are created implicitly by "cp -r".
You'll need to ensure the permissions match the packages too.
>
> BTW, what's the purpose of Targetdirs? Is it only used as a
> conveninet way to create directories, or is it also used to
> track *every* new subdirs on the system?
It's not for tracking. It's both a convenient way to create
directories (so you don't have to have lots of Makefile rules
or shell code to create a, a/b, a/b/c.... in the right order
with the right permissions) and as a way to avoid parallel
build race conditions.
I would say that if all these erlang directories are forever
private to the usr/src/cmd/erlang build then you could leave
them out of Targetdirs too. If you ever expect something
like usr/src/cmd/erlang-niftynewthing to be integrated and
want to put things in those directories, then it's better
if they are in Targetdirs so both don't have to know how
to create them.
>
>> 4. usr/src/pkgdefs/SUNW*/copyright
>> Just my normal comment about the length of the 'copyright' files :-(
>> Have noticed lately, in reviews, that some people are using
>> the short version. (Ignore if you so wish)
>
> I saw the discussion, though I am not sure what's the final
> dicission(I think the prefered way is to incude the whole
> license?). What the short version is like? Is it just a URL?
> (BTW, this is EPL, not GPL)
Include the whole license as we seem to be heading that way.
Mike
