Zach, Here are a few comments from my quick skip through (otherwise it looks okay to me), see below ...
Zach Kissel wrote: > > Please review the code for libdvdnav's integration into the sfw consolidation > > The webrev is located at: http://cr.opensolaris.org/~zk194757/libdvdnav/ === Start of Comments === 1. usr/src/lib/libdvdnav/Makefile.sfw Maybe you could use the predefine 'configure --prefix=' from Makefile.master, for an example see http://cr.opensolaris.org/~rayx/erlang/webrev/usr/src/cmd/erlang/Makefile.sfw.html 2. usr/src/pkgdefs/Makefile Put in alphabetical order 3. usr/src/pkgdefs/SUNWlibdvdnav/depend I don't think you need this file; you are using the default one from SUNWlibdvdnav/Makefile and this looks like the default anyway. === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
