Zach, Zach Kissel wrote: > Thanks for you comments Paul. I've made the changes to the webrev and have > posted it in the same location > (http://cr.opensolaris.org/~zk194757/libdvdnav/) explanations of my changes > appear inline.
This looks okay to me Paul >>I missed a bit, added below ... >> >>Paul Cunningham wrote: >>> >>>Here are a few comments from my quick skip through >> >>(otherwise it looks >> >>>okay to me), see below ... >>> >>>Zach Kissel wrote: >>> >>> >>>>Please review the code for libdvdnav's integration >> >>into the sfw >> >>>>consolidation >>>> >>>>The webrev is located at: >> >>http://cr.opensolaris.org/~zk194757/libdvdnav/ >> >>> >>>=== Start of Comments === >>> >>>1. usr/src/lib/libdvdnav/Makefile.sfw >>> Maybe you could use the predefine 'configure >> >>--prefix=' from >> >>> Makefile.master, for an example see >>> >> >>http://cr.opensolaris.org/~rayx/erlang/webrev/usr/src/ >>cmd/erlang/Makefile.sfw.html >> > > Looked into this and made the appropriate changes to > usr/src/lib/libdvdnav/Makfile.sfw. > > >>>2. usr/src/pkgdefs/Makefile >>> Put in alphabetical order >>> > > > Done. > > >>>3. usr/src/pkgdefs/SUNWlibdvdnav/depend >>> I don't think you need this file; you are using >> >>the default >> >>> one from SUNWlibdvdnav/Makefile and this looks >> >>like the >> >>> default anyway. >> > > This is correct. I'm using the default one, so I've removed this stray depend > file. > > >>4. METADATA >> You don't seem to have a METADATA file > > > It appears that some ports include this and some ports don't for completeness > I've included one in my port. > > > >>== End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
