Hi Paul, Changes related to METADATA and copyright are done and also the webrev is uploaded. Let me know if I am missing anything.
http://cr.opensolaris.org/~vivekrt/6835987-bcel/ Thanks, ~Vivek R. Titarmare -----Original Message----- From: Paul Cunningham [mailto:[email protected]] Sent: Friday, May 08, 2009 4:07 PM To: Vivek Titarmare Cc: sfwnv-discuss at opensolaris.org Subject: Re: [sfwnv-discuss] Request code review for "bcel" Vivek, This mainly looks good to me, but see comments below ... Paul Vivek Titarmare wrote: > I have posted a webrev for package "bcel" which I am porting to Neveda > and would like to request a code review. Please see the link below > > http://cr.opensolaris.org/~vivekrt/6835987-bcel/ 1. usr/src/lib/bcel/METADATA Update to conform to ... "http://wikis.sun.com/display/SFWNotes/METADATA"; Please also do all your other pkgs waiting for review also. The SRC: link doesn't give me a download tarball, it probably needs to be something like ... "http://www.apache.org/dist/jakarta/bcel/source/bcel-5.2-src.tar.gz"; The URL: line, why have you put a link to the licence here rather than to the project home-page? 2. usr/src/pkgdefs/SUNWbcel/copyright Do you need to add any source-owner copyright lines to the top of this? END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
