Looks good to me paul
Vivek Titarmare wrote: > > Changed the download link and also the PROJECT_URL. Re uploaded the webrev. > > Let me know if this looks ok. > > http://cr.opensolaris.org/~vivekrt/6835987-bcel/ > > Thanks, > ~Vivek R. Titarmare > > -----Original Message----- > From: Paul Cunningham [mailto:paul.cunningham at tadpole.com] > Sent: Tuesday, May 12, 2009 1:08 PM > To: Vivek Titarmare > Cc: sfwnv > Subject: Re: [sfwnv-discuss] Request code review for "bcel" > > See below ... > > Vivek Titarmare wrote: > >> Let me know if this is correct. >> http://cr.opensolaris.org/~vivekrt/6835987-bcel/ > >>> Vivek Titarmare wrote: >>>> I have posted a webrev for package "bcel" which I am porting to Neveda >>>> and would like to request a code review. Please see the link below >>>> >>>> http://cr.opensolaris.org/~vivekrt/6835987-bcel/ > > >>> 1. usr/src/lib/bcel/METADATA > >>> The SRC: link doesn't give me a download tarball, it >>> probably needs to be something like ... >>> "http://www.apache.org/dist/jakarta/bcel/source/bcel-5.2-src.tar.gz"; > > your link still doesn't give me a tarball download (it goes to a webpage) > >>> The URL: line, why have you put a link to the licence >>> here rather than to the project home-page? > > and you still seem to have this > > > Every thing else looks okay -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
