Vivek - Some minor questions and comments.
When I built the pdsh packages, I choose to add the --with-ssh option to configure. Anyone interested in security these days surely uses ssh regularly and might want to use it with pdsh as well. I also install the executables dshbak pdcp pdsh rpdcp rpdsh is a link to pdsh, so maybe it is not needed, but it is produced by make install. A user familiar with pdsh might want rpdsh. You have a very complicated patch for configure, for example. What is the justification for these patches? I found no reason for such major changes when I did my builds. Steve C. Bharath Kumar wrote: > Hi Vivek, > > >From my quick skip through, the webrev mainly looks good to me. Minor > comments below. > > 1. Please update the METADATA file as per Norms guidelines at " > http://wikis.sun.com/display/SFWNotes/METADATA " > > 2. In *usr/src/cmd/pdsh/install-sfw * > please change > > #! /usr/bin/sh > > TO > > #!/usr/bin/ksh93 > > 3. Since you are using default depend file, please remove the file > *usr/src/pkgdefs/SUNWpdsh/depend > *and instead add the below entry in > *usr/src/pkgdefs/SUNWpdsh/Makefile* > > DATAFILES= depend > > Thanks > Bharath > > > Vivek Titarmare wrote: >> >> I have posted a webrev for package "pdsh" which I am porting to Nevada >> and would like to request a code review. Please see the link below >> >> >> >> http://cr.opensolaris.org/~vivekrt/6833847-pdsh/ >> <http://cr.opensolaris.org/%7Evivekrt/6833847-pdsh/> >> >> >> >> >> >> Thanks, >> >> ~Vivek R. Titarmare >> >> >> >> >> >> >> >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> sfwnv-discuss mailing list >> sfwnv-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >> > > ------------------------------------------------------------------------ > > _______________________________________________ > sfwnv-discuss mailing list > sfwnv-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
