Hi Vivek, The updated webrev looks good to me.
Thanks Bharath Vivek Titarmare wrote: > > Hi Bharath, > > > > Pl. see my comments [INLINE] > > > > Also uploaded is the updated webrev for pdsh at > > http://cr.opensolaris.org/~vivekrt/6833847-pdsh/ > <http://cr.opensolaris.org/%7Evivekrt/6833847-pdsh/> > > > > > > Let me know if I am missing anything. > > > > Thanks, > > ~Vivek R. Titarmare > > > > *From:* Bharath.Madakatte at Sun.COM [mailto:Bharath.Madakatte at Sun.COM] > *Sent:* Wednesday, May 13, 2009 12:35 PM > *To:* Vivek Titarmare > *Cc:* sfwnv-discuss at opensolaris.org > *Subject:* Re: [sfwnv-discuss] Request code review for "pdsh" > > > > Hi Vivek, > > From my quick skip through, the webrev mainly looks good to me. Minor > comments below. > > 1. Please update the METADATA file as per Norms guidelines at " > http://wikis.sun.com/display/SFWNotes/METADATA " > <http://wikis.sun.com/display/SFWNotes/METADATA> > > [VIVEK] done. > > > > 2. In *usr/src/cmd/pdsh/install-sfw * > please change > > #! /usr/bin/sh > > TO > #!/usr/bin/ksh93 > > [VIVEK] done. > > 3. Since you are using default depend file, please remove the file > *usr/src/pkgdefs/SUNWpdsh/depend > *and instead add the below entry in > *usr/src/pkgdefs/SUNWpdsh/Makefile* > > DATAFILES= depend > > [VIVEK] done. > > Thanks > Bharath > > > Vivek Titarmare wrote: > > I have posted a webrev for package "pdsh" which I am porting to Nevada > and would like to request a code review. Please see the link below > > > > http://cr.opensolaris.org/~vivekrt/6833847-pdsh/ > <http://cr.opensolaris.org/%7Evivekrt/6833847-pdsh/> > > > > > > Thanks, > > ~Vivek R. Titarmare > > > > > > > > > ------------------------------------------------------------------------ > > > > > _______________________________________________ > sfwnv-discuss mailing list > sfwnv-discuss at opensolaris.org <mailto:sfwnv-discuss at opensolaris.org> > http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/sfwnv-discuss/attachments/20090514/a4ca8224/attachment.html>
