kang zhao wrote:
> Hi all,
>
> Please review the webrev of guile/autogen.
>
> http://cr.opensolaris.org/~kz196224/guile_autogen/
>
Great job!
Just a few things...
I would update autogen to 5.9.7.
I would update guile to 1.8.6.
usr/src/cmd/autogen/install-sfw
- you should pass the PKGVERS variable in from Makefile.sfw
28 PKGVERS=autogen-5.9
usr/src/cmd/guile/install-sfw
- you should pass the VERS variable in from Makefile.sfw
34 VERS=guile-1.8.4
usr/src/cmd/guile/install-sfw-64
- you should pass the VERS variablies in from Makefile.sfw
34 VER=guile-1.8.4
35 VER64=${VER}-64
usr/src/pkgdefs/SUNWautogen/copyright
- you can remove this redundant copyright statement.
15 Copyright (C) 1998, 1999, 2000, 2002 Gary V. Vaughan
Cheers,
Jim
