Kenny, Here are some more comments for you ...
Paul kang zhao wrote: > > Please review the webrev of guile/autogen. > Based on comments, there is some code change accordingly. > > *add 64bit library to guile > > *include a 64bit library file to libltdl in this webrev > 64bit guile compiling need 64bit libltdl to compile 64bit first. > > *change all METADATA file to new format > > *change all install-sfw file to standard format > > > http://cr.opensolaris.org/~kz196224/guile_autogen/ 1. usr/src/cmd/autogen/Makefile.sfw Extract the VER= info from the METADATA After the VER= line add ... TARBALL=$(VER).tar.gz and then replace '$(VER).tar.gz' with '$(TARBALL)' elsewhere in the file Line ... 45 (cd $(VER); env SRC=$(SRC) \ change 'env ' to 'env - ' Do the following need to be define in the rules 'all:' and 'install:' ? ... LD_LIBRARY_PATH=$(ROOTLIB BINDIR=$(ROOT)/usr/bin ROOTBIN=$(ROOTBIN) 2. usr/src/cmd/autogen/install-sfw Pass the PKGVERS= info in from the Makefile.sfw (so this file doesn't have to be updated for each new source- version update). Cosmetic: add ... # <line-space> after (so it conforms) .. 20 # CDDL HEADER END eg. 19 # 20 # CDDL HEADER END # 21 # 22 # Copyright 2009 Sun Microsystems, Inc. All rights reserved. And also check all your other files. 3. Source package versions Why are you delivery older versions than are available in the community? 4. usr/src/cmd/guile/Makefile.sfw Similar comments to (2) above. Line ... 71 $(SRC)/tools/protofix --pkg SUNWguile --perm you could extract the SUNW pkg name from the METADATA (may also apply to autogen/Makefile.sfw) Change as .. Roland Mainz wrote: > use either $(SHELL) or /usr/bin/bash for "configure" > calls (so we know which one is used and "configure" > doesn't pick one itself) (may also apply to autogen/Makefile.sfw) 5. usr/src/cmd/guile/install-sfw Pass the VERS= info in from the Makefile.sfw Is this correct ... 43 rm -rf ${ROOT}/1.8 it seems to remove stuff at /1.8 in the proto area? 6. usr/src/cmd/guile/install-sfw-64 Pass the VERS= info in from the Malefile.sfw Delete line ... 60 cd ${TOP} I think it's not required 7. usr/src/cmd/libtool/Makefile.sfw You may want to change it so it extracts the VER= info from the METADATA (and does that METADATA conform?) Maybe: 'env ' to 'env - ', etc. 8. usr/src/cmd/libtool/install-sfw-64 Delete line ... 43 cd ${TOP} Change top-of-file stuff so it conforms. 9. usr/src/pkgdefs/SUNWautogen/prototype_com This is a GNU tool, shouldn't it install into /usr/gnu and have symbolic links in /usr - if not shouldn't there be symbolic links for it in /usr/gnu ? The same applies to guile. -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
