Paul Cunningham wrote: > Brian, > > Mainly looks okay to me, but see below .... >
>> I have fixed the man pages though. > > okay lets take install-sfw as an example, compare .. > > "http://cr.opensolaris.org/~blu/ntpv4/sfwnv-webrev/usr/src/cmd/ntpd/install-sfw.html"; > > > with > "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/prototype.ksh"; > > > > and you will see there is a missing line-space after ... > 20 # CDDL HEADER END > 21 # > (I did say it was cosmetic) - I just like new things to conform :-) and > it then stops it being propagate when someone else uses your file as an > example. > > There are other differences in other files (not all) Okay, I get it now. As I said, I previously fixed the man pages. I have now also updated install-sfw, Solaris/ntp, RtNTPMngmnt.html, SmfNTPStates.html and SmfValueNTP.html. These last three don't have prototypes, but they were not totally consistent with each other. Nor does the manifest have a prototype, but the header is already what I would guess it should be. >>>>> 18. usr/src/cmd/ntpd/Solaris/ntprc.4 >>>>> Have you delivered this in a SUNW pkg, I can't see where? >>>> >>>> It is a file format of an optional file, not delivered. >>> >>> so if its not used why not remove it - to stop confusion >> >> The file is used, it just isn't delivered. Somewhat similar to the >> ntp.conf file, although two example files are delivered for ntp.conf. > > Okay if you say so :-) but I still can't see where it's used - so just > out of interest please explain to me where it is used (and so can't be > removed). The commands ntp-keygen, ntpdc and ntpq can use this file, as noted in their own man pages. > You having mentioned ntp.conf, I can't see that this is delivered also > so why is a man page, ntp.conf.4, delivered for it? If the man page is > to explain how to setup up a ntp.conf file them maybe the pkg should > also deliver an example ntp.conf file (I can see it doing that). Note: > man-pages in the webrev form are too hard to read so I haven't. There are two sample ntp.conf files delivered already, /etc/inet/ntp.server and /etc/inet/ntp.client. -- blu "Mark my words, nanotechnology is going to be huge!" ---------------------------------------------------------------------- Brian Utterback - Solaris RPE, Sun Microsystems, Inc. Ph:877-259-7345, Em:brian.utterback-at-ess-you-enn-dot-kom
