Mainly looks good to me, see comments below ... Paul
Vivek Titarmare wrote: > I have posted a webrev for package "aspectjrt" which I am porting to > Nevada and would like to request a code review. Please see the link below > > http://cr.opensolaris.org/~vivekrt/6835985-aspectjrt/ 1. usr/src/lib/aspectjrt/METADATA Maybe the SOURCE_DOWNLOAD: path should be ... "http://download.eclipse.org/tools/aspectj/aspectj-1.6.3-src.jar"; to take you straight there. 2. usr/src/pkgdefs/SUNWaspectjrt/copyright Should this include a copy of the "Eclipse Public License" ? "http://www.opensource.org/licenses/eclipse-1.0.php"; 3. general How is this compiler invoked? The manual talks about using 'ajc' to compile stuff ... "http://www.eclipse.org/aspectj/doc/released/progguide/examples-howto.html"; are you delivering that somewhere? END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
