Hi Paul, The changes are done for point 1 & 2. On point 3: ajc is not required for compiling at presently. We are compiling using java and generating couple of jar file from aspectjrt which are required by StorageIM package.
The new webrev is uploaded. Let me know if I am missing anything. http://cr.opensolaris.org/~vivekrt/6835985-aspectjrt Thanks, ~Vivek R. Titarmare -----Original Message----- From: Paul Cunningham [mailto:[email protected]] Sent: Friday, May 15, 2009 7:27 PM To: Vivek Titarmare Cc: sfwnv-discuss at opensolaris.org Subject: Re: [sfwnv-discuss] Request code review for "aspectjrt" Mainly looks good to me, see comments below ... Paul Vivek Titarmare wrote: > I have posted a webrev for package "aspectjrt" which I am porting to > Nevada and would like to request a code review. Please see the link below > > http://cr.opensolaris.org/~vivekrt/6835985-aspectjrt/ 1. usr/src/lib/aspectjrt/METADATA Maybe the SOURCE_DOWNLOAD: path should be ... "http://download.eclipse.org/tools/aspectj/aspectj-1.6.3-src.jar"; to take you straight there. 2. usr/src/pkgdefs/SUNWaspectjrt/copyright Should this include a copy of the "Eclipse Public License" ? "http://www.opensource.org/licenses/eclipse-1.0.php"; 3. general How is this compiler invoked? The manual talks about using 'ajc' to compile stuff ... "http://www.eclipse.org/aspectj/doc/released/progguide/examples-howto.html"; are you delivering that somewhere? END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
