Updated webrev posted at the same location: http://cr.opensolaris.org/~gvasick/6838600/
Thanks, George Paul Cunningham wrote: > George, > > This mainly looks good to me, but see comments below ... > > George Vasick wrote: >> >> Please review my changes for the upgrade of autoconf from 2.61 to 2.63: >> >> http://cr.opensolaris.org/~gvasick/6838600/ > > 1. usr/src/cmd/autoconf/Makefile.sfw > Change 'env ' to 'env - ' on line ... > 51 cd $(VER); env SRC=$(SRC) \ > > Do these need to be defined ? ... > 53 BINDIR=$(ROOT)/usr/bin \ > 54 MANDIR=$(ROOT)/usr/share/man/man1 \ > > Line ... > 72 ./configure --prefix=/usr) > could be changed so it uses the predefined '--prefix=' > from Makefile.master, eg. change to ... > $(SHELL) ./configure $(CONFIGURE_OPTIONS)) > > > Is the sunman-stability stuff getting added to the man pages? > ($(SRC)/tools/protofix --manscript ....) > > 2. usr/src/pkgdefs/SUNWaconf/copyright > Is that the correct 'Sun disclaimer' at the top, it looks > different/shorter to most others I've seen. > > You should probably add the source-owner copyright lines, > extracted from the tarball files, after the Sun disclaimer > > END
