Pradhap Devarajan wrote: > Hi George, > Small change use we d'nt have to explicitly untar the sources. When > you define TARBALL in Makefile, it automatically takes care of untar'ing > sources. You can just use > > $(VER)/configure: > $(TOUCH) $(VER)/configure
It is not working for me: (northbowl:bash) autoconf: make -f Makefile.sfw clean install rm -rf autoconf-2.63 /usr/bin/touch autoconf-2.63/configure touch: cannot create autoconf-2.63/configure: No such file or directory *** Error code 1 make: Fatal error: Command failed for target `autoconf-2.63/configure' Current working directory /export/home/george/autoconf/usr/src/cmd/autoconf Is there something else I need to set up? > > Use $(TOUCH) and $(CFGPREFIX) for "/usr" instead of hardcoding the path. I find the hard coded path more legible and easier to understand. Use of these macros obscures to code for me. Am I the only one? What is the benefit of using the macros? I am pretty sure we could not simply redefine the macros to new locations and have the build succeed. At a minimum, the prototype files are full of hard coded pathnames that would need to be revised. Also, we create relative links during the installs. This could get real tricky if supporting redefinition of the macros is our intention. Thanks, George > > ~ Pradhap.D > > Paul Cunningham wrote: >> George, >> >> This looks okay to me >> >> Paul >> >> George Vasick wrote: >>> Updated webrev posted at the same location: >>> >>> http://cr.opensolaris.org/~gvasick/6838600/ >> >>>> George Vasick wrote: >>>>> >>>>> Please review my changes for the upgrade of autoconf from 2.61 to >>>>> 2.63: >>>>> >>>>> http://cr.opensolaris.org/~gvasick/6838600/ >> >> _______________________________________________ >> sfwnv-discuss mailing list >> sfwnv-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
