Hi Li Fan,
Not done this for a while so I'll probably miss stuff:
1. usr/src/lib/aalib/Makefile.sfw
- What's PREFIX used for? It doesn't seem to override anything and it's
not used anywhere else in the Makefile?
- Did you really want 'echo ${CONFIGURE_OPTIONS};' in your ./configure
line in $(VER)/config.status
- Seems that 'rmdir tmp' in the $(VER64)/configure target will always
fails seeing as you moved it in the previous line, if that's the case
then remove it
2. usr/src/lib/aalib/aalib-config.1
- Is this file also in the source tarball? If it is and you are not
changing it then why not install it with '_install M' from your
install-sfw script as you do with the other man pages? If it's your own
man page then it needs a copyright header.
3. usr/src/pkgdefs/Makefile
- Check the diffs for this file, you are removing other components.
Resync your workspace with the gate or the clone and regenerate the webrev
I don't see /usr/demo/aalib being created anywhere which means that you
relying on something to implicitly create it for you. You should add
/usr/demo/aalib to usr/src/Targetdirs and have the build environment
create it for you. There are several other examples of demo directories
in Targetdirs.
Amanda
Li Fan wrote:
> Hi!
>
> After ARC review, the aalib package code needs to be updated
> according to ARC member's comments.
>
>
> The modification includes:
>
> 1) Moved these binaries from /usr/bin to /usr/demo/aalib,
> and remove the 64-bit version of them:
> aafire,
> aainfo,
> aasavefont,
> aatest
>
> 2) Add a man page for /usr/bin/aalib-config
>
>
> Here is the webrev:
> http://cr.opensolaris.org/~fan.li/aalib
>
>
> Thanks!
> -- Li Fan
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
