Hi Amanda, Thank you very much for your comments. It is a great help to me.* <javascript:void(0)>*
New webrev is at http://cr.opensolaris.org/~fan.li/aalib/ , including the changes inline... Amanda Waite wrote: > Hi Li Fan, > > Not done this for a while so I'll probably miss stuff: > > 1. usr/src/lib/aalib/Makefile.sfw > > - What's PREFIX used for? It doesn't seem to override anything and > it's not used anywhere else in the Makefile? > - Did you really want 'echo ${CONFIGURE_OPTIONS};' in your ./configure > line in $(VER)/config.status Yes. These are useless. Removed. > - Seems that 'rmdir tmp' in the $(VER64)/configure target will always > fails seeing as you moved it in the previous line, if that's the case > then remove it I didn't see the failure in the log. Would you please give me the fail output? Here is my log: " mkdir -p tmp gzip -dc aalib-1.4rc5.tar.gz | (cd tmp; /usr/sfw/bin/gtar xpf -) mv tmp/aalib-1.4rc5 aalib-1.4rc5-64 rmdir tmp (cd aalib-1.4rc5-64; env - \ CC=/ws/onnv-tools/SUNWspro/SS12/bin/cc "CFLAGS=-xO3 -m64 -xarch=generic -Ui386 -U__i386 -Xa -xildoff -xc99=all " \ "LDFLAGS=" \ PATH="/ws/onnv-tools/SUNWspro/SS12/bin:/export/home/sfwnv/usr/src/tools/proto/opt/onbld/bin:/export/home/sfwnv/usr/src/tools/proto/opt/onbld/bin/i386:/opt/onbld/bin:/opt/onbld/bin/i386:/opt/SUNWspro/bin:/usr/ccs/bin:/usr/bin:/usr/sbin:/usr/ucb:/usr/etc:/usr/openwin/bin:/usr/sfw/bin:/opt/sfw/bin:." \ /usr/bin/ksh93 ./configure --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info) " > > 2. usr/src/lib/aalib/aalib-config.1 > > - Is this file also in the source tarball? If it is and you are not > changing it then why not install it with '_install M' from your > install-sfw script as you do with the other man pages? If it's your > own man page then it needs a copyright header. This is my own man page. I will add copyright header to it. > > 3. usr/src/pkgdefs/Makefile > > - Check the diffs for this file, you are removing other components. > Resync your workspace with the gate or the clone and regenerate the webrev Because I did not sync workspace with the gate. Now the two Makefile is the newest. > > > > I don't see /usr/demo/aalib being created anywhere which means that > you relying on something to implicitly create it for you. You should > add /usr/demo/aalib to usr/src/Targetdirs and have the build > environment create it for you. There are several other examples of > demo directories in Targetdirs. Thanks. I also found the failure in nightly build because /usr/demo/aalib hadn't been created. Added entries for "/usr/demo/aalib" and "/usr/share/doc/aalib" to usr/src/Targetdirs > > Amanda > > > > > Li Fan wrote: >> Hi! >> >> After ARC review, the aalib package code needs to be updated >> according to ARC member's comments. >> >> >> The modification includes: >> >> 1) Moved these binaries from /usr/bin to /usr/demo/aalib, >> and remove the 64-bit version of them: >> aafire, >> aainfo, >> aasavefont, >> aatest >> >> 2) Add a man page for /usr/bin/aalib-config >> >> >> Here is the webrev: >> http://cr.opensolaris.org/~fan.li/aalib >> >> >> Thanks! >> -- Li Fan >> _______________________________________________ >> sfwnv-discuss mailing list >> sfwnv-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >
