Michal Bachorik - Sun Microsystems - Prague Czech Republic wrote: > Amanda, > > yep, I can do that. But I assure you that you can ignore the lines in > both makefiles that are removing stuff - you know, each time, when I > resync the workspace I need to rebuild everything and it takes time, > so when I do "webrev" again there is great chance that Makefiles are > again out of sync. >
I don't think that it's really possible for a code reviewer to approve a webrev when it has issues like this. At some point you have to do a putback and you need to be synced with the gate before then. That situation is no different when generating a webrev, pretend that we are the gate system. The way I do it is to resync with the gate/clone, build just my component, if it's clean, generate the webrev and upload it to cr.opensolaris.org and then run nightly while waiting for a review. Thanks Amanda > Regards, > > Michal > > > Amanda Waite wrote: >> Sorry, I looked over it when you first posted it but never had a >> chance to do a review. >> >> First can you resync your workspace with the clone and regenerate the >> webrev (and repost). In both >> >> usr/src/cmd/Makefile >> usr/src/pkgdefs/Makefile >> >> you are removing stuff (everything with a '-' next to it). >> >> In the meantime I'll find time today to do a complete review. >> >> Thanks >> >> Amanda >> >> >> >> Michal Bachorik - Sun Microsystems - Prague Czech Republic wrote: >>> Hi all, >>> >>> I am looking for a reviewer for a freeipmi project, already ARC >>> approved (http://arc.opensolaris.org/caselog/PSARC/2009/245/). The >>> webrev is accessible at http://cr.opensolaris.org/~jf222792/sfwnv_wr/. >>> >>> Thanks in advance, >>> >>> Michal Bachorik >>> >>> _______________________________________________ >>> sfwnv-discuss mailing list >>> sfwnv-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >> >
