I've run through the webrev and as ever it looks like Paul has uncovered
most if not all of the issues. One thing I did see:
usr/src/cmd/freeipmi/install-sfw
- You create ${ROOT}/var/svc/manifest/system and the build system
should be creating it for you. I'm surprised it doesn't already but you
must be the first to integrate a system service into SFW. Add an entry
for /var/svc/manifest/system in 'usr/src/Targetdirs' there's a section
there that includes all of the manifest paths. Remember to remove the
mkdir from install-sfw.
If you make this change, the changes I mentioned earlier and the ones
that Paul has suggested and then update the webrev, I'll run through it
again and tell you if I see anything else.
Thanks
Amanda
Michal Bachorik - Sun Microsystems - Prague Czech Republic wrote:
> Hi,
>
> I am still looking for someone willing to do a review :)
>
> Cheers,
>
> Michal
>
> Michal Bachorik - Sun Microsystems - Prague Czech Republic wrote:
>> Hi all,
>>
>> I am looking for a reviewer for a freeipmi project, already ARC
>> approved (http://arc.opensolaris.org/caselog/PSARC/2009/245/). The
>> webrev is accessible at http://cr.opensolaris.org/~jf222792/sfwnv_wr/.
>>
>> Thanks in advance,
>>
>> Michal Bachorik
>>
>> _______________________________________________
>> sfwnv-discuss mailing list
>> sfwnv-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
>
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
