Great! Thanks again, Paul! Cheers, Lily
Paul Cunningham wrote: > Lily, > > This looks good to me now > > Paul > > Lily Li wrote: >> >> Many thanks for your quick review and good comments! >> I updated the 3 files you mentioned below, please reload >> http://cr.opensolaris.org/~lilyli/shmux/ to take a look again. >> >> Thanks, >> Lily >> >> Paul Cunningham wrote: >>> Lily, >>> >>> This mainly looks good to me, see below for a few minor comments ... >>> >>> Paul >>> >>> Lily Li wrote: >>>> >>>> I am working on porting shmux, an useful tool for executing the >>>> same command on many hosts in parallel. Could you please take some >>>> time to review the codes? >>>> >>>> webrev at: http://cr.opensolaris.org/~lilyli/shmux/ >>> >>> 1. usr/src/cmd/shmux/METADATA >>> Make the NAME: field more descriptive >>> >>> 2. usr/src/cmd/shmux/sunman-stability >>> I don't think you need the CDDL HEADER and Copyright stuff >>> at the top of this. >>> >>> 3. usr/src/pkgdefs/SUNWshmux/depend >>> Its normal to include all the dependencies from the >>> default 'depend' as well. >>> >
