Hi Sriram, Many thanks for review!
Sriram Natarajan wrote: > - I don't see any where what CONFIGURE_OPTIONS value really > translates to . Did you miss this accidentally ? > The default CONFIGURE_OPTIONS has been defined by usr/src/Makefile.master: 168 # Common configure options with common values 169 CONFIGURE_OPTIONS = --prefix=$(CFGPREFIX) 170 CONFIGURE_OPTIONS += --mandir=$(CFGMAN) and by default, CFGPREFIX=/usr CFGMAN=/usr/share/man they are needed by shmux package to install, otherwise, it will be installed to /usr/local by default. > - Looks like your package depends on pcre. But, I don't see you are > configuring to use 'pcre' component > I added pcre dependency as I found the following info in shmux/INSTALL file: -- shmux dependencies shmux will make use of the following programs if they are available on the system (and found in the PATH). They are not required but allow using certain optional features of shmux. See the man page for details. + fping: http://www.fping.com/ + ssh: http://www.openssh.org/, ... Also, if you want Perl Compatible Regular Expression support, you'll need the PCRE library: + pcre: http://www.pcre.org/ In other words, without fping/ssh/pcre, shmux still works but some features are missed. So I'm not sure whether I need to add all these dependencies? bash-3.2# pkginfo |grep -i ssh system SUNWsshcu SSH Common, (Usr) system SUNWsshdr SSH Server, (Root) system SUNWsshdu SSH Server, (Usr) system SUNWsshr SSH Client and utilities, (Root) system SUNWsshu SSH Client and utilities, (Usr) bash-3.2# pkginfo |grep -i fping system SUNWfping fping - a program to ping hosts in parallel system SUNWfpingr fping - a program to ping hosts in parallel (Root) bash-3.2# pkginfo |grep -i pcre system SUNWpcre Perl-Compatible Regular Expressions Thanks, Lily > > - sriram > > Lily Li wrote: >> A kind reminder... >> >> Lily Li wrote: >>> Hi All, >>> >>> I need one more expert at least to review the codes. Any feedbacks >>> are very appreciated! >>> >>> Thanks, >>> Lily >>> >>> Lily Li wrote: >>>> Hi All, >>>> >>>> I am working on porting shmux, an useful tool for executing the >>>> same command on many hosts in parallel. Could you please take some >>>> time to review the codes? >>>> >>>> webrev at: http://cr.opensolaris.org/~lilyli/shmux/ >>>> >>>> Many thanks! >>>> >>>> Lily >> _______________________________________________ >> sfwnv-discuss mailing list >> sfwnv-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
