George, See my comments below ...
Paul George Vasick wrote: > > I am upgrading m4 to the latest stable version. Summary of changes: > > 1) upgrade gm4 from 1.4.2 to 1.4.12 > 2) add missing man page > 3) include additional info pages > 4) install in /usr/gnu (PSARC/2007/047) > 5) removed /usr/sfw/bin/gm4 link (/usr/sfw is obsolete) > > Please review my changes: > http://cr.opensolaris.org/~gvasick/gm4/ 1. usr/src/cmd/gm4/METADATA Add the SUPPORT: level 2. usr/src/cmd/gm4/Makefile.sfw Does it still need this ? ... 45 @find . -name core -exec rm -f {} \; 3. usr/src/pkgdefs/SUNWgm4/copyright Do you need the add the sun disclaimer stuff and the pkg src owner copyright lines (from the src files in the unpacked source tarball)? As done in ... "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/"; 4. usr/src/pkgdefs/SUNWgm4/prototype_com Copyright year needs updating 5. usr/src/pkgdefs/SUNWsfinf/prototype_com Copyright year needs updating 6. usr/src/cmd/gm4/install-gm4 You could pass in the PKGVERS= stuff from the Makefile.sfw Maybe change as .. Roland Mainz wrote: > use /usr/bin/ksh93 or /usr/bin/bash for install-* > and add a $ set -o errexit # at the beginning > and replace ". ${SRC}/tools/install.subr" with > "source ${SRC}/tools/install.subr" (the idea is to > catch failures in the script and abort it at that point, > right now the script will just continue) I don't think this is used now (delete) ... 37 SFWPREFIX=${ROOT}/usr/sfw As its moved from sfw to gnu, for backwards compatibility shouldn't there be a symbolic in usr/sfw/bin for gm4 ? (I saw your item above, but just checking) -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
