Hi Paul, Thanks for you help. Changes made and webrev updated:
http://cr.opensolaris.org/~gvasick/gm4/ See comments below. Paul Cunningham wrote: > George, > > See my comments below ... > > Paul > > George Vasick wrote: >> >> I am upgrading m4 to the latest stable version. Summary of changes: >> >> 1) upgrade gm4 from 1.4.2 to 1.4.12 >> 2) add missing man page >> 3) include additional info pages >> 4) install in /usr/gnu (PSARC/2007/047) >> 5) removed /usr/sfw/bin/gm4 link (/usr/sfw is obsolete) >> >> Please review my changes: >> http://cr.opensolaris.org/~gvasick/gm4/ > > 1. usr/src/cmd/gm4/METADATA > Add the SUPPORT: level Done. > > 2. usr/src/cmd/gm4/Makefile.sfw > Does it still need this ? ... > 45 @find . -name core -exec rm -f {} \; Done. > > 3. usr/src/pkgdefs/SUNWgm4/copyright > Do you need the add the sun disclaimer stuff and the > pkg src owner copyright lines (from the src files in > the unpacked source tarball)? As done in ... > "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/"; I am not sure what needs to be done here. The copyright file is a copy of the COPYING file from the source tarball. I didn't see anything in the link you provided that corresponds to a disclaimer for a copyright file itself. What am I missing? > > 4. usr/src/pkgdefs/SUNWgm4/prototype_com > Copyright year needs updating Done. > > 5. usr/src/pkgdefs/SUNWsfinf/prototype_com > Copyright year needs updating Done. > > 6. usr/src/cmd/gm4/install-gm4 > You could pass in the PKGVERS= stuff from > the Makefile.sfw > > Maybe change as .. > Roland Mainz wrote: > > use /usr/bin/ksh93 or /usr/bin/bash for install-* > > and add a $ set -o errexit # at the beginning > > and replace ". ${SRC}/tools/install.subr" with > > "source ${SRC}/tools/install.subr" (the idea is to > > catch failures in the script and abort it at that point, > > right now the script will just continue) Done. > > I don't think this is used now (delete) ... > 37 SFWPREFIX=${ROOT}/usr/sfw > > As its moved from sfw to gnu, for backwards compatibility > shouldn't there be a symbolic in usr/sfw/bin for gm4 ? > (I saw your item above, but just checking) I got the same comment from Rainer in another email. Let me reply to this issue there. I hope that is OK. Thanks again, George
