Hi Paul, Thanks comments, I have modified the webrev. http://cr.opensolaris.org/~bjwancn/commons-collections/
Best Regards! -James On 03/13/09 21:31, Paul Cunningham wrote: > James, > > This main looks good to me, see below for my minor comments ... > > Paul > > jin wan - Sun Microsystems - Beijing China wrote: >> >> I am porting "commons-collections", which extends or augments the >> Java Collections Framework. >> It's a component of Apache Common project. >> It's also a dependent jar package for "dbunit" porting. >> >> Would you please have a review on my code. The webrev is at: >> http://cr.opensolaris.org/~bjwancn/commons-collections/ > > 1. usr/src/lib/commons-collections/Makefile.sfw > You could define '(PKGNAME)-$(PKGVER)-src' as > something, eg. .... > SRCNAME=(PKGNAME)-$(PKGVER)-src > and then use $(SRCNAME) everywhere else > '(PKGNAME)-$(PKGVER)-src' is used. > > Similarly you could define TARBALL .. > TARBALL=$(SRCNAME).tar.gz > and use $(TARBALL) everywhere else > $(PKGNAME)-$(PKGVER)-src.tar.gz is used > > It might be better to apply the patch ... > 40 $(GPATCH) -p0 < ../build.xml.patch; > in the rule .. > 48 $(PKGNAME)-$(PKGVER): > after the unpack of the tarball > > 2. usr/src/lib/commons-collections/install-sfw > You don't need the 'pragma ' on ... > 27 # pragma ident "@(#)install-sfw ...." > > The other files that have it don't need it either. > > 3. usr/src/pkgdefs/SUNWcommons-collections/prototype_com > I think you need to add the lines for dirs ... > d none usr/share/lib/java/javadoc .... > d none usr/share/lib/java/javadoc/commons ... > d none usr/share/lib/java/javadoc/commons/collections .. > plus any other that might be missing >
