usr/src/lib/dbunit/METADATA* * - No need for a CDDL header in the METADATA file - Add a Name field as per the METADATA section of http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines - Add other fields (SRC, SUPPORT, BUGTRAQ)
usr/src/lib/dbunit/Makefile.sfw - Set DBUNIT with values from the METADATA file: $(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh) - In the 'all' target use 'env -' in place of 'env' - In the 'install' target', replace $(SH) with $(SHELL) <- which is ksh93 usr/src/cmd/mpg123/install-sfw - add 'set -o errexit' as the first line after the ident string - Pass in 'VER' from Makefile.sfw, i.e.: VER=$(DBUNIT) $(SHELL) ./install-sfw usr/src/lib/dbunit/sunman/dbunit.3.sunman - Interface Stability is External. Where did this come from? External is now Volatile, is there an ARC case for DBUnit? usr/src/pkgdefs/SUNWdbunit/prototype_com - Just use the package name as the final comment instead of "SUNWdbunit - JUnit database extension" usr/src/pkgdefs/SUNWdbunit/prototype_sparc, usr/src/pkgdefs/SUNWdbunit/prototype_i386 - Add the following as the final comments for consistency # source locations relative to the prototype file # # # SUNWdbunit # CDDL headers for all files - Make sure all the CDDL headers and Copyright notices conform to: http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/ Amanda jin wan - Sun Microsystems - Beijing China wrote: > Hi All, > > I am porting 'dbunit', which is a JUnit extension for database-driven > projects test to OpenSolaris, > > Would you please have a review on my code. The webrev is at: > > http://cr.opensolaris.org/~bjwancn/dbunit/ > > Thanks! > -James > > _______________________________________________ > sfwnv-discuss mailing list > sfwnv-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
