Great, looks good to me.
Amanda
John Cui wrote:
>
>
> Amanda Waite wrote on 06/03/09 17:26:
>>> Using the PERL from ${SRC}/Makefile.master. However there are some
>>> install-sfw depend on $PERL from $SRC/tools/install.subr since
>>> "_install P"
>> It's fine if the _install functions use $PERL from install.subr, but
>> those functions are liable to change and $PERL doesn't seem to me to
>> be part of what install.subr exports, it's an internal variable.
> After source ${SRC}/tools/install.subr, $PERL is from install.subr, it
> is not an internal var.
>
>> Why not use $PERLmaster everywhere you use $PERL?
> At that time, I thought $PERL from install.subr is used to build,
> $PERL from ${SRC}/Makefile.master is for target host.
> You are right, I change it.
>
> Please reload http://cr.opensolaris.org/~johncui/6840288/
>>
>> If you leave it as it is I'll be happy, at least the shebang for the
>> perl scripts you are integrating will be ok. Hopefully one day
>> they'll have a single $PERL variable for the entire workspace.
>>
>> Everything else looks ok.
>>
>> Amanda
> Thanks,
> --
> John Cui
> x82195
>
