John Cui wrote:
> Hi all,
> Could you kindly review 6840288? 
> http://cr.opensolaris.org/~johncui/6840288/
>
> The fix is pretty simple and straightforward. It uses 
> /usr/perl5/bin/perl instead of /usr/bin/perl, and uses cp instead of mv.

I agree with Paul about making directories, leave that to the build 
system by adding your directories to usr/src/Targetdirs.

I think that depending on $PERL from $SRC/tools/install.subr might lead 
to problems. I think it's set there to be used by itself, not to be 
exported. So if they change the script then they might break your build. 
There is a $PERL available for the Makefile (defined in 
${SRC}/Makefile.master), you could pass it in from there when you call 
the script, something like:

PERL=$(PERL) $(SHELL) ./install-sfw

Amanda

>
> Thanks,
> -- 
> John Cui
> x82195
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
>   


Reply via email to