Hi folks, thank you very much for comments. I fixed as many things as possible. Please let me know what else should be fixed. Have a nice weekend ;-) Jan Forch, Sun Microsystems
Current webrev presentation is on: http://cr.opensolaris.org/~jf222792/sfwnv_rc3 === Start of Comments === 1. usr/src/cmd/freeipmi/METADATA Update as per "SFW Package writing guidelines" ... "http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines"; FIXED 2. usr/src/pkgdefs/Makefile & usr/src/cmd/Makefile Resync with gate/clone FIXED 3. usr/src/pkgdefs/SUNWfreeipmir/depend & SUNWfreeipmir/Makefile Use the default 'depend' rather than this in the root package FIXED 4. SUNWfreeipmir/Makefile & SUNWfreeipmiu/Makefile where is these ? FIXED 5. File Copyright year Correct this in all relevant files FIXED 6. Top of file layout Fix this in all files as per ... "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/"; FIXED 7. usr/src/cmd/freeipmi/Makefile.sfw Extract the VER= info from the METADATA - there are numerous examples in gate now. FIXED Lines ... 61 MAKE=$(CCSMAKE) \ 62 DESTDIR="$(ROOT)" \ 63 INSTALL=/usr/bin/ginstall you could put these before the '$(CCSMAKE) install', and for lines 68-70. FIXED Do you need to use 'protofix' to fix the permissions on files installed with 'make install' ? (see comment 13) PERMISSIONS SEEMS TO BE OK Lines 84-91 and 95-103 ... use the predefined '--prefix=' value from Makefile.master ie, something like ... CONFIGURE_OPTIONS += --with-dont-check-for-root CONFIGURE_OPTIONS += --sysconfdir=/etc etc. .... $(SHELL) ./configure $(CONFIGURE_OPTIONS) FIXED 8. usr/src/cmd/freeipmi/install-sfw Change as per ... Roland Mainz wrote: > use /usr/bin/ksh93 for install-sfw* and add a > $ set -o errexit # at the beginning and replace > ". ${SRC}/tools/install.subr" with > "source ${SRC}/tools/install.subr" (the idea is to catch > failures in the script and abort it at that point, > right now the script will just continue) FIXED Why don't you use the '_install' macro rather than ginstall? FIXED Man pages: why not edit the man pages files and then install into the proto area with '_install M ..) WHAT IS DIFFERENCE BETWEEN THIS AND CURRENT SOLUTION? its the more standard way of doing it in the sfw gate, for example "http://src.opensolaris.org/source/xref/sfw/usr/src/lib/readline/install-sfw"; # manpages is converted by sunman-stability sed-script to # append the stability and availability. MANSCRIPT=sunman-stability for MANSUBDIR in ${MANDIR}/* do if [ x`echo ${MANSUBDIR} | grep man[3578]$` != x ] && [ -d ${MANSUBDIR} ]; then echo "MANSUBDIR: ${MANSUBDIR}" for MANPAGE in ${MANSUBDIR}/* do _install M ${MANPAGE} ${MANPAGE} 444 // sunman-stability script usage if [ x`echo ${MANPAGE} | grep 5$` != x ] && [ -f ${MANPAGE} ]; then NEWMANPAGE=`echo ${MANPAGE} | sed -e 's/\/man5\//\/man4\//' -e 's/\.5$/\.4/'` echo ${NEWMANPAGE} mv -f ${MANPAGE} ${NEWMANPAGE} // rename man page files in compliance with Solaris man page categories fi if [ x`echo ${MANPAGE} | grep 7$` != x ] && [ -f ${MANPAGE} ]; then NEWMANPAGE=`echo ${MANPAGE} | sed -e 's/\/man7\//\/man5\//' -e 's/\.7$/\.5/'` echo ${NEWMANPAGE} mv -f ${MANPAGE} ${NEWMANPAGE} fi if [ x`echo ${MANPAGE} | grep 8$` != x ] && [ -f ${MANPAGE} ]; then NEWMANPAGE=`echo ${MANPAGE} | sed -e 's/\/man8\//\/man1m\//' -e 's/\.8$/\.1m/'` echo ${NEWMANPAGE} mv -f ${MANPAGE} ${NEWMANPAGE} fi done fi done WHAT EXACTLY SHOULD I CHANGE TO HAVE IT MORE STANDARD? 9. usr/src/cmd/freeipmi/sunman-stability Where is the stability stuff? Add line for where to get source from on opensolaris.org? SHOULD BE OK NOW PLEASE HAVE A LOOK AGAIN 10. usr/src/pkgdefs/SUNWfreeipmir/pkginfo.tmpl DESC= line, put pkg version at end of line, eg. DESC="................... (0.7.7)" FIXED 11. usr/src/pkgdefs/SUNWfreeipmir/prototype_com & usr/src/pkgdefs/SUNWfreeipmiu/pkginfo.tmpl Line ... 53 f none etc/ipmi_monitoring_sensors.conf does this file need to be preserved over SUNW pkg update? (may be others) YES Lines ... ARCH="i386" VERSION="11.11.0,REV=2009.04.03.13.50" are wrong - this looks like the file has been built - get .tmpl file from another package in the gate/clone FIXED 12. usr/src/pkgdefs/SUNWfreeipmiu/depend Again this looks like the default 'depend' - have you checked you have no other dependencies with the dependency checker script? FIXED OUTPUT OF DEPENDENCY CHECKER: > make check_deps ==== Checking package dependencies ==== /usr/perl5/bin/perl /builds4/jf222792/sfwnv_rc2/usr/src/tools/check-deps.pl -e /builds4/jf222792/sfwnv_rc2/usr/src/tools/exception_list.check-deps -d /builds4/jf222792/sfwnv_rc2/packages/i386/nightly-nd -p /net/netinstall/export/nv/x/latest/Solaris_11/Product SUNW0sfw SUNWa2psr SUNWa2psu SUNWaconf SUNWactivation SUNWaget SUNWantlr2 SUNWapchd SUNWapchr SUNWapchu SUNWapr13lib SUNWapr13dev SUNWapr13doc SUNWapu13lib SUNWapu13dev SUNWapu13doc SUNWapu13dbd-mysql SUNWapu13dbd-pgsql SUNWapu13dbd-sqlite SUNWapu13-ldap SUNWapch22d SUNWapch22r SUNWapch22u SUNWapch22m-php52 SUNWapch22r-php52 SUNWapch22m-fcgid SUNWapch22r-fcgid SUNWapch22m-jk SUNWapch22r-jk SUNWapch22m-security SUNWapch22r-security SUNWapch22m-dtrace SUNWapch22r-dtrace SUNWapch22m-sed SUNWapch22r-sed SUNWant SUNWstringtemplate SUNWantlr SUNWawstats SUNWbash SUNWbcc SUNWbinutils SUNWbison SUNWbonnieplus SUNWbwm-ng SUNWbzip SUNWcglib SUNWcimserverr SUNWcimserveru SUNWclisp SUNWcmake SUNWconflict SUNWconvmv SUNWcupsr SUNWcupsu SUNWcurl SUNWcvs SUNWdom4j SUNWdoxygen SUNWdrools SUNWdwdiff SUNWelinks SUNWerlang SUNWerlang-doc SUNWepydoc SUNWexpect SUNWfcgi SUNWfcgi-doc SUNWunrar SUNWunzip SUNWdvdrw SUNWfetchmail SUNWffiltersr SUNWffiltersu SUNWfftw2 SUNWfftw3 SUNWflexlex SUNWflexruntime SUNWfping SUNWfpingr SUNWfoomatic-db SUNWfoomatic-db-enginer SUNWfoomatic-db-engineu SUNWfppd SUNWfreeipmir SUNWfreeipmiu SUNWgawk SUNWgcc SUNWgccruntime SUNWgcmn SUNWgdb SUNWgd2 SUNWghostscriptr SUNWghostscriptu SUNWgimpprint SUNWgpch SUNWggrp SUNWgit SUNWgm4 SUNWgmake SUNWgnu-automake-19 SUNWgnu-automake-110 SUNWgnu-coreutils SUNWgnu-dbm SUNWgnu-diffutils SUNWgnu-emacs SUNWgnu-emacs-el SUNWgnu-emacs-gtk SUNWgnu-emacs-nox SUNWgnu-emacs-x SUNWgnu-gettext SUNWgnu-gperf SUNWgnu-idn SUNWgnu-mc SUNWgnu-mp SUNWgnu-mpfr SUNWgnu-nano SUNWgnu-readline SUNWgnu-which SUNWgocr SUNWgrails SUNWgsed SUNWgsfot SUNWgsfst SUNWgtar SUNWGlib SUNWGtkr SUNWGtku SUNWgvim SUNWgzip SUNWhal-cups-utilsr SUNWhal-cups-utils SUNWhexedit SUNWhpijs SUNWhttping SUNWiftop SUNWilmbase SUNWimagick SUNWImperius SUNWiperf SUNWipmi SUNWipmir SUNWircii SUNWjavamail SUNWjruby SUNWlablgtk SUNWjanino SUNWjarjar SUNWjaxb SUNWjaxen-core SUNWjdtcore SUNWjdom SUNWjettison SUNWjodatime SUNWjunit SUNWjxl SUNWkonkretcmpi SUNWlcms SUNWless SUNWlexpt SUNWlftpr SUNWlftpu SUNWlibconfuse SUNWlibevent SUNWlibmcrypt SUNWlibmemcached SUNWlibmng SUNWlibnet SUNWlibopenusb SUNWlibpcap SUNWlibrsync SUNWlibsigsegv SUNWlibsndfile SUNWlibtool SUNWlinks SUNWlogrotater SUNWlogrotateu SUNWlog4j SUNWlighttpd14r SUNWlighttpd14u SUNWltdl SUNWlua SUNWlxml SUNWlxmlr SUNWlxml-devel SUNWlxml-python SUNWlxsl SUNWlxsl-devel SUNWlxsl-python SUNWmeld SUNWmemcached SUNWmemcachedr SUNWmemcached-java SUNWmercurial SUNWmkcd SUNWmkcdr SUNWmrtg SUNWmrxvt SUNWmtx SUNWmutt SUNWmuttr SUNWmvel SUNWmysqlr SUNWmysqlt SUNWmysqlu SUNWmysql5u SUNWmysql5r SUNWmysql5test SUNWmysql5jdbc SUNWmysql51r SUNWmysql51u SUNWmysql51lib SUNWmysql51test SUNWncft SUNWneon SUNWnethack SUNWnethackr SUNWnmap SUNWntpr SUNWntpu SUNWobjectasm SUNWocaml SUNWopenexr SUNWopenldapr SUNWopenldapu SUNWopenssl-commands SUNWopenssl-include SUNWopenssl-libraries SUNWopenssl-man SUNWopensslr SUNWopenwsmanr SUNWopenwsmanu SUNWp7zip SUNWpampkcs11r SUNWpampkcs11u SUNWpampkcs11-docs SUNWpatchutils SUNWpconsole SUNWpcre SUNWpen SUNWpenr SUNWperl-pmtools SUNWpgadmin3 SUNWpgbouncer-pg83-config SUNWpgbouncer-pg83-server SUNWphp52d SUNWphp52u SUNWphp52r SUNWphp52u-mysql SUNWphp52r-mysql SUNWphp52u-pear SUNWphp52r-pear SUNWphp52u-pgsql SUNWphp52r-pgsql SUNWpmdbi SUNWpmdbdpg SUNWpostgr-82-client SUNWpostgr-82-contrib SUNWpostgr-82-devel SUNWpostgr-82-docs SUNWpostgr-82-libs SUNWpostgr-82-pl SUNWpostgr-82-server SUNWpostgr-82-server-data-root SUNWpostgr-82-jdbc SUNWpostgr-82-tcl SUNWpostgr-83-client SUNWpostgr-83-contrib SUNWpostgr-83-devel SUNWpostgr-83-docs SUNWpostgr-83-libs SUNWpostgr-83-pl SUNWpostgr-83-server SUNWpostgr-83-server-data-root SUNWpostgr-83-tcl SUNWpostgr-83-tests SUNWpostgr-jdbc SUNWpostgr-upgrade SUNWpowermanr SUNWpowermanu SUNWprivoxyr SUNWprivoxyu SUNWprocmail SUNWpsutils SUNWpull-parser SUNWpycups SUNWpython-pyopenssl SUNWpython26-pyopenssl SUNWpwgen SUNWquiltr SUNWquiltu SUNWrdiff-backup SUNWrelaxngDatatype SUNWrpm SUNWrsync SUNWruby18u SUNWruby18r SUNWsaaj SUNWsane-backendr SUNWsane-backendu SUNWsane-frontend SUNWSblimCimClient SUNWsblimwbemcli SUNWscreen SUNWscreenrc SUNWserr SUNWseru SUNWserweb SUNWsfdoc SUNWsfinf SUNWsfman SUNWsfwdemo SUNWsfwhea SUNWsg3utilsr SUNWsg3utilsu SUNWsimplewbem SUNWslang SUNWslangr SUNWslrn SUNWsmbar SUNWsmbau SUNWsnack SUNWsqlite3 SUNWsqlite3docs SUNWsqlite3tcl SUNWsquidr SUNWsquidu SUNWstunnelr SUNWstunnelu SUNWsudor SUNWsudou SUNWsvn SUNWsvn-java SUNWsvn-perl SUNWsvn-python SUNWswig SUNWTcl SUNWtcltls SUNWtcatr SUNWtcatu SUNWtcsh SUNWtexi SUNWtidy SUNWTk SUNWtop SUNWtor SUNWtor-root SUNWtree SUNWtss SUNWtss-root SUNWunison SUNWunixodbcr SUNWunixodbc SUNWvim SUNWwgetr SUNWwgetu SUNWxpp3min SUNWxsdlib SUNWxstream SUNWxom SUNWzlib SUNWzlibr SUNWzip SUNWzsh SUNWsmmgr SUNWsmagt SUNWsmdoc SUNWsmcmd SUNWlibusb SUNWlibusbugen SUNWquaggar SUNWquaggau SUNWbind SUNWbindr SUNWslib SUNWwebalizer SUNWwebalizerr SUNWwebminu SUNWwebminr SUNWwireshark SUNWwiresharkr SUNWwisemanr SUNWwisemanu SUNWwxwidgets SUNWwxwidgets-devel SUNWusbccid SUNWdiffstat SUNWcsu > 13. usr/src/pkgdefs/SUNWfreeipmiu/prototype_com Do not install files in /usr with the write permision bit set. FIXED 14. First can you resync your workspace with the clone and regenerate the webrev (and repost). In both usr/src/cmd/Makefile usr/src/pkgdefs/Makefile=== End of Comments === FIXED 15. Also, some of your files appear to have been checked out when you created the webrev, they have ident strings like: #ident "%Z%%M% %I% %E% SMI" Instead of like: # ident "@(#)install.sfw 1.3 09/04/09 SMI" FIXED -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/sfwnv-discuss/attachments/20090605/70d3f5ad/attachment.html>
