See comments below .. paul
Jan Forch wrote: > > thank you very much for comments. I fixed as many things as possible. > Please let me know what else should be fixed. Have a nice weekend ;-) > > Current webrev presentation is on: > http://cr.opensolaris.org/~jf222792/sfwnv_rc3 you got me most confused as your html email link took me to .. http://cr.opensolaris.org/~jf222792/sfwnv_rc rather than .. http://cr.opensolaris.org/~jf222792/sfwnv_rc3 > 1. usr/src/cmd/freeipmi/METADATA The SOURCE_DOWNLOAD: doesn't give me the tarball you downloaded > 6. Top of file layout > Fix this in all files as per ... > "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/"; they still don't exactly conform, ie. there are missing line-spaces (but it is only cosmetic). > 7. usr/src/cmd/freeipmi/Makefile.sfw > Do you need to use 'protofix' to fix the permissions on > files installed with 'make install' ? (see comment 13) > PERMISSIONS SEEMS TO BE OK are you sure they are installed into the ws proto area with the same permissions as in the prototype_com file ? 'make install' doesn't normally (have you done a full ws build again to check?) > > Lines 84-91 and 95-103 ... > use the predefined '--prefix=' value from Makefile.master > ie, something like ... > CONFIGURE_OPTIONS += --with-dont-check-for-root > CONFIGURE_OPTIONS += --sysconfdir=/etc > etc. > .... > $(SHELL) ./configure $(CONFIGURE_OPTIONS) > FIXED you don't need these though .. 53 CONFIGURE_OPTIONS += --prefix=/usr 58 CONFIGURE_OPTIONS += --mandir=/usr/share/man as they are predefined in Makefile.master Add $(SHELL) before calling 'configure', so you know what shell it uses .. env - $(TARGET_ENV) $(SHELL) ./configure $(CONFIGURE_OPTIONS)) > 11. usr/src/pkgdefs/SUNWfreeipmir/prototype_com > & usr/src/pkgdefs/SUNWfreeipmiu/pkginfo.tmpl > Line ... > 53 f none etc/ipmi_monitoring_sensors.conf > does this file need to be preserved over SUNW pkg update? > (may be others) > YES it doesn't look as tough it does to me > 12. usr/src/pkgdefs/SUNWfreeipmiu/depend copyright stuff should be after the 'CDDL HEADER END' -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
