Ed, See comments below ...
Paul Ed Posnak wrote: > The BIND update project is updating ISC BIND to the latest version. > Please help us out by providing comments before June 15, 2009. The > webrev is at http://cr.opensolaris.org/~posnake/sfwnv/ > <http://cr.opensolaris.org/%7Eposnake/sfwnv/> 1. usr/src/cmd/bind/METADATA The SOURCE_DOWNLOAD: link does not point to the downloadable tarball. The version on the VERSION: line is not the same as that on the tarball you are using. Shouldn't the PROJECT_URL: link really point to ... http://www.isc.org/software/bind rather than to the opensolaris project page? 2. usr/src/cmd/bind/Makefile.sfw Extract the VER= info from the METADATA, see examples in the gate. Line .. 44 @find . -name core -exec rm -f {} \; is this really needed, if not remove it. If it is needed, why is it needed? (there are others as well) Lines 80-90, change so that it uses the predefined --prefix= value from Makefile.master (ie. $(CFGPREFIX)), or better still change this all to use the ... ./configure $(CONFIGURE_OPTIONS) method, eg something like ... CONFIGURE_OPTIONS += --with-libtool CONFIGURE_OPTIONS += --bindir="/usr/sbin" CONFIGURE_OPTIONS += --sbindir="/usr/sbin" CONFIGURE_OPTIONS += --libdir="/usr/lib/dns" etc. ..... ..... $(SHELL) ./configure $(CONFIGURE_OPTIONS)) again there are various examples in the gate (cups) Cosmetic: add line-space after line 29 Change 'env ' to 'env - 'to make sure "configure" and "make" only see the env variables they should really get (and not pick-up any random env variable) 3. Tops of files (various files) Cosmetic: Change so that they conform to the prototypes in .. "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/"; 4. usr/src/pkgdefs/SUNWbind/depend & usr/src/pkgdefs/SUNWbindc/depend The Copyright lines should be after the 'CDDL HEADER END' header 5. usr/src/pkgdefs/SUNWbind/pkginfo.tmpl & usr/src/pkgdefs/SUNWbindc/pkginfo.tmpl Add the source pkg version at the end of the DESC= line, eg .. DESC="......... (x.x.x)" 6. usr/src/pkgdefs/SUNWbindc/Makefile & usr/src/pkgdefs/SUNWbind/Makefile Remove the null DATAFILES= line 7. usr/src/pkgdefs/SUNWbindc/Makefile & usr/src/pkgdefs/SUNWbind/Makefile Observation: should this really contain the prototype_com.new development stuff (lines 39-96), its most confusing; I think it would be better somewhere else (if its really required). END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
