Ed,

This mainly looks good to me now, there is a few minor comments below ..

Paul

Ed Posnak wrote:
> The BIND update project is updating to a newer non-beta version of ISC 
> BIND (9.6.1). Please help us out by providing comments before June 15, 
> 2009. The webrev is at http://cr.opensolaris.org/~posnake/bind-update/

1. usr/src/cmd/bind/METADATA
    Shouldn't the PROJECT_URL: link really point to the
    community page ...
     http://www.isc.org/software/bind
    rather than to the opensolaris project page?

2. usr/src/cmd/bind/Makefile.sfw
    You don't need the line ..
      71 CONFIGURE_OPTIONS +=    --prefix=$(CFGPREFIX)
    as its predefined in Makefile.master for CONFIGURE_OPTIONS.

    Out of interest, where are lines 97 to 102 used ?

3. usr/src/pkgdefs/SUNWbind/prototype_i386
    I don't think you needed to change this as you have
    only changed the copyright year and tidied up the header. But
    its okay with me to leave it changed so its header conforms :-)

4. usr/src/pkgdefs/SUNWbind/Makefile
     & usr/src/pkgdefs/SUNWbindc/Makefile
    Same comment as before about the extra devel stuff in these.

END
-- 
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Business Unit

Reply via email to