George, This mainly looks okay to me, see below for some comments ..
Paul George Vasick wrote: > > Here is the webrev for the upgrade of flex to 2.5.35: > > http://cr.opensolaris.org/~gvasick/flex/ 1. usr/src/cmd/flex/METADATA Maybe a better PROJECT_URL: home page link would be what was there before, ie. http://flex.sourceforge.net/ 2. usr/src/cmd/flex/Makefile.sfw Change all 'env ' to 'env - ' so it only see the env variables they should really get (and not pick-up any random env variable) Lines 81 and 92, use $(SHELL) for "configure" calls (so we know which one is used and "configure" doesn't pick one itself) eg. $(SHELL) ./configure .... Lines .. 109 -rm -rf $(VER) 110 -rm -rf $(VER64) combine them into a single invocation, eg. -rm -rf $(VER) $(VER64) 3. usr/src/cmd/flex/install-sfw & usr/src/cmd/flex/install-sfw-64 pass in the VERS= info from the Makefile.sfw (that in turn gets it from the METADATA). Change as ... Roland Mainz wrote: > use /usr/bin/ksh93 for install-sfw* and add a > $ set -o errexit # at the beginning and replace > ". ${SRC}/tools/install.subr" with > "source ${SRC}/tools/install.subr" (the idea is to catch > failures in the script and abort it at that point, > right now the script will just continue) Line .. 83 _install N ${cat} ${LOCALEDIR}/$i/LC_MESSAGES/flex.mo 644 does it need the write perm bit set? (and in prototype_com) END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
