George, Looking good, but see comments below ...
Paul George Vasick wrote: > > Thanks for the help. I think I have all of the changes covered. The > webrev has been updated: > http://cr.opensolaris.org/~gvasick/flex/ >> George Vasick wrote: >>> >>> Here is the webrev for the upgrade of flex to 2.5.35: >>> http://cr.opensolaris.org/~gvasick/flex/ >> 3. usr/src/cmd/flex/install-sfw > > & usr/src/cmd/flex/install-sfw-64 Change .. 1 #! /usr/bin/sh to .. #!/usr/bin/ksh93 4. usr/src/cmd/flex/install-sfw-64 Use the VERS passed in from the Makefile.sfw Plus ... >> Change as ... >> Roland Mainz wrote: >> > use /usr/bin/ksh93 for install-sfw* and add a >> > $ set -o errexit # at the beginning and replace >> > ". ${SRC}/tools/install.subr" with >> > "source ${SRC}/tools/install.subr" (the idea is to catch >> > failures in the script and abort it at that point, >> > right now the script will just continue) 5. usr/src/cmd/flex/install-sfw Line .. 54 _install N FlexLexer.h ${INCDIR}/FlexLexer.h 644 does it need the write perm bit set? (and in prototype_com) -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
