This mainly looks okay to me, but see below for a few comments ... Paul
Jan Hnatek wrote: > > please review my change to bring SUNWbash to the latest > official patch level in order to fix 6780158. > > Webrev: > http://cr.opensolaris.org/~hnhn/bash_6780158.pl49/ 1. usr/src/cmd/bash/Makefile.sfw Line 22, change copyright year Line .. 28 VER=bash-3.2 you could change this to extract the info from the METADATA file Patch level, you might want to add that into the METADATA in the COMMENTS: field Line .. 45 @find . -name core -exec rm -f {} \; is this actually needed, if not delete it. You could do these also .. Roland Mainz wrote: > use "env - ..." and not "env ..." in the Makefiles > to make sure "configure"&&"make" only see the env > variables they should really get > (and not pick-up any random env variable). > Use either $(SHELL) or /usr/bin/bash for "configure" calls > (so we know which one is used and "configure" doesn't pick > one itself) You also could do ... Line .. 64 ./configure --prefix=/usr \ use the predefined value for prefix from Makefile.master, eg ... ./configure --prefix=$(CFGPREFIX) \ Define TARBALL=, and then use the now built in stuff to unpack the tarball and apply the patches (see cups) END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
