Hi Jan, Few questions:
1. Do we have guarantee the patches will be applied in right order? 2. Would it be possible to merge both "$(VER)/configure" and "$(VER)/config.status" targets into one? Something like: $(VER)/config.status: $(VER)/.patched 3. Shouldn't we replace ".patched" in the line above with "$(SFW_STAMP_PATCHED)"? Thanks. On Wed, Jul 29, 2009 at 02:36:09PM +0200, Jan Hnatek wrote: > Hi Paul, Marcel, all, > > thanks for the review. > > Here's an updated version with patch level 50, > (including another fix for sparc only) and with > the points below answered (see inline please): > > http://cr.opensolaris.org/~hnhn/bash_6780158.pl50/ > > Any comments are welcome. > > Paul Cunningham wrote: >> This mainly looks okay to me, but see below for a few comments ... >> >> Paul >> >> Jan Hnatek wrote: >>> >>> please review my change to bring SUNWbash to the latest >>> official patch level in order to fix 6780158. >>> >>> Webrev: >>> http://cr.opensolaris.org/~hnhn/bash_6780158.pl49/ -- Marcel Telka Solaris RPE
