Hi Michal, Quick run-through found couple of issues. * usr/src/pkgdefs/SUNWfreeipmir/prototype_com - .conf files should be "e" type not "f" type
* usr/src/pkgdefs/SUNWfreeipmiu/depend - check if SUNWlibgpg-error package needs to be added because "ldd bmc-config" shows libgpg-error library. * *usr/src/cmd/freeipmi/bmc_intf.h - not sure from where this file originated, if its for special purpose add it to comments section of METADATA file. * usr/src/cmd/freeipmi/bmc-watchdog.xml - shouldn't it wait for filesystem/local * usr/src/cmd/freeipmi/ipmidetectd.xml.html usr/src/cmd/freeipmi/svc-ipmidetectd - your prefix is "/usr" but it refers to /*usr/local/etc/ipmidetectd.conf is it correct ? regards, Pradhap.D Michal Bachorik wrote: > Hi all, > > I am in an urgent need to re-review the freeipmi workspace (owned by > my colleague Jan Forch, working on freeipmi porting). The freeipmi > workspace has already been reviewed by Amanda Waite and Paul Cunnigham > almost a month ago, but recently a nightly build process has been > changed in a way, that freeipmi workspace nightly build was failing. > > The updated workspace has 2 new files that were not reviewed before: > > *usr/src/cmd/freeipmi/man-fix > **usr/src/cmd/freeipmi/man-fix-sed > > *The fix applies an extra sed script file on the man pages after untar > and before the build of package in a way that words "error" and "error > message" are filtered from man pages (the fix is supposed to work with > future versions of freeipmi as well). > * > *Webrev is located at > http://cr.opensolaris.org/~jf222792/sfwnv_o/ > > Thank you in advance, > > Michal > > _______________________________________________ > sfwnv-discuss mailing list > sfwnv-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
