1. usr/src/pkgdefs/SUNWfreeipmir/prototype_com
- If you want to preserve the conf file across pkgrm/pkgadd then you
need to change it from 'f' to 'e' and then specify which action class to
use, either renamenew or renameold, i.e.:
e renamenew etc/ipmi_monitoring_sensors.conf 0755 root bin
e renamenew etc/freeipmi.conf 0755 root bin
(they probably don't need the execute bits set)
- You also need to add the class to the list of 'packaging files' in
prototype_com
i i.renamenew
- and add the class to the classes field in pkginfo.tmpl
2. usr/src/pkgdefs/SUNWfreeipmiu/depend
- Have you run 'make check_deps' in ${SRC}/pkgdefs?
>. edit your sfw-developer.sh script. At the bottom, set SFW_PKGDB
>to point to the package directory of a current Solaris install image.
>> # SFW_PKGDB=/net/netinstall/export/nv/s/latest/Solaris_11/Product
>and use bldenv(1) or just set it in your env.
>2. cd usr/src/pkgdefs
>3. make check_deps.
3. usr/src/pkgdefs/SUNWfreeipmir/prototype_sparc
usr/src/pkgdefs/SUNWfreeipmir/prototype_i386
usr/src/pkgdefs/SUNWfreeipmiu/prototype_sparc
usr/src/pkgdefs/SUNWfreeipmiu/prototype_i386
- Where are these files? Are they in the workspace but not checked in?
I've never built anything without at least minimal versions of these
files, maybe SFW does build without them but I'd prefer to see them there.
4. usr/src/cmd/freeipmi/install-sfw
- echo "install.sfw" <- I guess this was left over from the debugging
5. usr/src/cmd/freeipmi/bmc_intf.h
- I couldn't work out where this file is used
Amanda
Michal Bachorik wrote:
> Hi all,
>
> I am in an urgent need to re-review the freeipmi workspace (owned by
> my colleague Jan Forch, working on freeipmi porting). The freeipmi
> workspace has already been reviewed by Amanda Waite and Paul Cunnigham
> almost a month ago, but recently a nightly build process has been
> changed in a way, that freeipmi workspace nightly build was failing.
>
> The updated workspace has 2 new files that were not reviewed before:
>
> *usr/src/cmd/freeipmi/man-fix
> **usr/src/cmd/freeipmi/man-fix-sed
>
> *The fix applies an extra sed script file on the man pages after untar
> and before the build of package in a way that words "error" and "error
> message" are filtered from man pages (the fix is supposed to work with
> future versions of freeipmi as well).
> *
> *Webrev is located at
> http://cr.opensolaris.org/~jf222792/sfwnv_o/
>
> Thank you in advance,
>
> Michal
>
