Amanda, thank you very much.
Regards, Michal Amanda Waite wrote: > Michal, > > See inline comments. > > Michal Bachorik wrote: >> Amanda, >> >> thanks a lot. The putback output looks better now :). But another >> question popped out - we used "wx pbchk" and it reported couple of >> issues (some of them looks like false positives), but anyway if you >> can spare a minute and give us short explanation, it would be great. >> I think that a short comment to each section would be enough with >> explanation in what form should we use the buster id new/changed >> files (there is warning, that comment in active list is not a bug id, >> but it is .. well, it is bugster placeholder bug id - should it be >> something else?). >> >> Regards, >> >> Michal >> >> Here is output from wx pbchk: >> >> >wx pbchk >> >> Doing cstyle check: >> >> Doing jstyle check: >> >> Doing header format check: >> >> Doing copyright check: >> usr/src/cmd/freeipmi/METADATA: no copyright message found >> usr/src/cmd/freeipmi/freeipmi-0.7.7.tar.gz: no copyright message found >> usr/src/cmd/freeipmi/man-fix-sed: no copyright message found >> usr/src/cmd/freeipmi/sunman-stability: no copyright message found >> usr/src/pkgdefs/SUNWfreeipmir/copyright: no copyright message found >> usr/src/pkgdefs/SUNWfreeipmiu/copyright: no copyright message found >> > > That's mostly ok, there's always a group of files that will fail this > check. You might want to add a Copyright notice to > usr/src/cmd/freeipmi/man-fix-sed > >> Doing CDDL block check: >> Warning: No CDDL block in file usr/src/cmd/freeipmi/METADATA >> Warning: No CDDL block in file >> usr/src/cmd/freeipmi/freeipmi-0.7.7.tar.gz >> Warning: No CDDL block in file usr/src/cmd/freeipmi/man-fix-sed >> Warning: No CDDL block in file usr/src/cmd/freeipmi/sunman-stability >> Warning: No CDDL block in file usr/src/pkgdefs/SUNWfreeipmir/copyright >> Warning: No CDDL block in file usr/src/pkgdefs/SUNWfreeipmiu/copyright > > Same as with the copyright check > >> >> Doing keywords check: >> Missing keywords in usr/src/cmd/freeipmi/METADATA >> Expanded keywords in usr/src/cmd/freeipmi/Makefile.sfw >> Expanded keywords in usr/src/cmd/freeipmi/bmc-watchdog.xml >> Missing keywords in usr/src/cmd/freeipmi/freeipmi-0.7.7.tar.gz >> Expanded keywords in usr/src/cmd/freeipmi/install-sfw >> Expanded keywords in usr/src/cmd/freeipmi/ipmidetectd.xml >> Expanded keywords in usr/src/cmd/freeipmi/man-fix >> Missing keywords in usr/src/cmd/freeipmi/man-fix-sed >> Missing keywords in usr/src/cmd/freeipmi/sunman-stability >> Expanded keywords in usr/src/cmd/freeipmi/svc-bmc-watchdog >> Expanded keywords in usr/src/cmd/freeipmi/svc-ipmidetectd >> Expanded keywords in usr/src/pkgdefs/SUNWfreeipmir/Makefile >> Missing keywords in usr/src/pkgdefs/SUNWfreeipmir/copyright >> Expanded keywords in usr/src/pkgdefs/SUNWfreeipmir/depend >> Expanded keywords in usr/src/pkgdefs/SUNWfreeipmir/pkginfo.tmpl >> Expanded keywords in usr/src/pkgdefs/SUNWfreeipmir/prototype_com >> Expanded keywords in usr/src/pkgdefs/SUNWfreeipmir/prototype_i386 >> Expanded keywords in usr/src/pkgdefs/SUNWfreeipmir/prototype_sparc >> Expanded keywords in usr/src/pkgdefs/SUNWfreeipmiu/Makefile >> Missing keywords in usr/src/pkgdefs/SUNWfreeipmiu/copyright >> Expanded keywords in usr/src/pkgdefs/SUNWfreeipmiu/depend >> Expanded keywords in usr/src/pkgdefs/SUNWfreeipmiu/pkginfo.tmpl >> Expanded keywords in usr/src/pkgdefs/SUNWfreeipmiu/prototype_com >> Expanded keywords in usr/src/pkgdefs/SUNWfreeipmiu/prototype_i386 >> Expanded keywords in usr/src/pkgdefs/SUNWfreeipmiu/prototype_sparc > > This is very worrying. When you checkout say Makefile.sfw, does it > have the ident string as a set of tokens like: > > # ident "%Z%%M% %I% %E% SMI" > > Or does it look like: > > # ident "@(#)Makefile.sfw 1.3 09/04/09 SMI" > > This might explain the 'Expanded keywords' message. The 'Missing > keywords message' is much the same as with the previous two sections. > > If the ident string isn't > > # ident "%Z%%M% %I% %E% SMI" (note: all white space is a single > tab except for the last (between % S) > > for all of the files when checked out, replace what's there with that > string and check the files back in. > > >> >> Doing sccs rmdel check: >> >> Doing multi delta check: >> >> Doing comments check: >> Warning, the following comments are found in your active list >> that are neither bug or arc cases: >> >> 6863639 > > Your comments for each file need to be of the form <CR #> <CR Synopsis> > > Use 'wx ea' to easily change the comments >> >> ---- End of active list comment warnings ---- >> >> Doing RTI check: >> >> Warning: no bug ID's in active list. > > That's because of the problem in the comments check > > > Amanda > > >> >> Doing out check: >> Workspace nametable changed: sccs_dirs out of date >> Updating /builds4/jf222792/sfwnv_p/wx/sccs_dirs...this may take a few >> minutes. >> >> >> And here is putback -n output, I hope it's fine now: >> >> > wx pb -n >> putback: User jf222792 does not have access to putback to workspace >> "/ws/sfwnv-clone" (Warning 2065) >> Parent workspace: /ws/sfwnv-clone >> Child workspace: /builds4/jf222792/sfwnv_p >> >> Examined files: 28 >> >> Would put back contents changes: 28 >> >> update: usr/src/Targetdirs >> update: usr/src/cmd/Makefile >> update: usr/src/pkgdefs/Makefile >> create: usr/src/cmd/freeipmi/METADATA >> create: usr/src/cmd/freeipmi/Makefile.sfw >> create: usr/src/cmd/freeipmi/bmc-watchdog.xml >> create: usr/src/cmd/freeipmi/freeipmi-0.7.7.tar.gz >> create: usr/src/cmd/freeipmi/install-sfw >> create: usr/src/cmd/freeipmi/ipmidetectd.xml >> create: usr/src/cmd/freeipmi/man-fix >> create: usr/src/cmd/freeipmi/man-fix-sed >> create: usr/src/cmd/freeipmi/sunman-stability >> create: usr/src/cmd/freeipmi/svc-bmc-watchdog >> create: usr/src/cmd/freeipmi/svc-ipmidetectd >> create: usr/src/pkgdefs/SUNWfreeipmir/Makefile >> create: usr/src/pkgdefs/SUNWfreeipmir/copyright >> create: usr/src/pkgdefs/SUNWfreeipmir/depend >> create: usr/src/pkgdefs/SUNWfreeipmir/pkginfo.tmpl >> create: usr/src/pkgdefs/SUNWfreeipmir/prototype_com >> create: usr/src/pkgdefs/SUNWfreeipmir/prototype_i386 >> create: usr/src/pkgdefs/SUNWfreeipmir/prototype_sparc >> create: usr/src/pkgdefs/SUNWfreeipmiu/Makefile >> create: usr/src/pkgdefs/SUNWfreeipmiu/copyright >> create: usr/src/pkgdefs/SUNWfreeipmiu/depend >> create: usr/src/pkgdefs/SUNWfreeipmiu/pkginfo.tmpl >> create: usr/src/pkgdefs/SUNWfreeipmiu/prototype_com >> create: usr/src/pkgdefs/SUNWfreeipmiu/prototype_i386 >> create: usr/src/pkgdefs/SUNWfreeipmiu/prototype_sparc >> >> Examined files: 28 >> >> Contents Summary: >> 25 create >> 3 update >> 6 differentiate child >> >> Amanda Waite wrote: >>> On other point, before putback -n or the real putback, make sure you >>> diff >>> >>> usr/src/Targetdirs >>> usr/src/cmd/Makefile >>> usr/src/pkgdefs/Makefile >>> >>> in your workspace against the files in the gate. >>> >>> Make sure you are only adding your stuff, not removing someone else's. >> >> >>> >>> Amanda >>> >>> >>> >>> Michal Bachorik wrote: >>>> Amanda, >>>> >>>> you seem to be most responsive person, so I'd like to ask you for >>>> small help. As we (me and Jan Forch) are working for the first time >>>> on porting, and we finally reached the phase cteam. To proceed, we >>>> need to use output from "putback -n". Can you please look at that >>>> output (from our workspace) a tell me, if it is ok? I am confused >>>> by words "your putback would be blocked" - it evokes a feeling in >>>> me, that there is something wrong. >>>> >>>> Output is below. >>>> >>>> Thx a lot, >>>> >>>> Michal >>>> >>>> ------------------------------------------------------ >>>> >>>> wx pb -n >>>> putback: User jf222792 does not have access to putback to workspace >>>> "/ws/sfwnv-clone" (Warning 2065) >>>> Parent workspace: /ws/sfwnv-clone >>>> Child workspace: /builds4/jf222792/sfwnv_p >>>> >>>> Examined files: 28 >>>> >>>> Would put back contents changes: 25 >>>> >>>> create: usr/src/cmd/freeipmi/METADATA >>>> create: usr/src/cmd/freeipmi/Makefile.sfw >>>> create: usr/src/cmd/freeipmi/bmc-watchdog.xml >>>> create: usr/src/cmd/freeipmi/freeipmi-0.7.7.tar.gz >>>> create: usr/src/cmd/freeipmi/install-sfw >>>> create: usr/src/cmd/freeipmi/ipmidetectd.xml >>>> create: usr/src/cmd/freeipmi/man-fix >>>> create: usr/src/cmd/freeipmi/man-fix-sed >>>> create: usr/src/cmd/freeipmi/sunman-stability >>>> create: usr/src/cmd/freeipmi/svc-bmc-watchdog >>>> create: usr/src/cmd/freeipmi/svc-ipmidetectd >>>> create: usr/src/pkgdefs/SUNWfreeipmir/Makefile >>>> create: usr/src/pkgdefs/SUNWfreeipmir/copyright >>>> create: usr/src/pkgdefs/SUNWfreeipmir/depend >>>> create: usr/src/pkgdefs/SUNWfreeipmir/pkginfo.tmpl >>>> create: usr/src/pkgdefs/SUNWfreeipmir/prototype_com >>>> create: usr/src/pkgdefs/SUNWfreeipmir/prototype_i386 >>>> create: usr/src/pkgdefs/SUNWfreeipmir/prototype_sparc >>>> create: usr/src/pkgdefs/SUNWfreeipmiu/Makefile >>>> create: usr/src/pkgdefs/SUNWfreeipmiu/copyright >>>> create: usr/src/pkgdefs/SUNWfreeipmiu/depend >>>> create: usr/src/pkgdefs/SUNWfreeipmiu/pkginfo.tmpl >>>> create: usr/src/pkgdefs/SUNWfreeipmiu/prototype_com >>>> create: usr/src/pkgdefs/SUNWfreeipmiu/prototype_i386 >>>> create: usr/src/pkgdefs/SUNWfreeipmiu/prototype_sparc >>>> >>>> The following files are currently checked out and have been edited >>>> in workspace >>>> "/builds4/jf222792/sfwnv_p": >>>> usr/src/Targetdirs >>>> usr/src/cmd/Makefile >>>> usr/src/pkgdefs/Makefile >>>> >>>> Your putback command would be blocked. >>>> >>>> Examined files: 28 >>>> >>>> Contents Summary: >>>> 25 create >>>> 3 no action (unchanged) >>>> >>>> No changes were put back >>> >> >
