Amanda, thank you very much once again.
Michal Amanda waite wrote: > Looks fine, don't forget to run wx ea so that the comments on all > files are the same. > > Amanda > > Jan Forch wrote: >> Hi Amanda, >> everything is fixed and should be ok. Please could you check outputs >> of pbchk and pb -n and current webrev: >> http://cr.opensolaris.org/~jf222792/sfwnv_p >> >> Thank you >> Jan Forch >> >> > wx pbchk >> >> Doing cstyle check: >> >> Doing jstyle check: >> >> Doing header format check: >> >> Doing copyright check: >> usr/src/cmd/freeipmi/METADATA: no copyright message found >> usr/src/cmd/freeipmi/freeipmi-0.7.7.tar.gz: no copyright message found >> usr/src/cmd/freeipmi/sunman-stability: no copyright message found >> usr/src/pkgdefs/SUNWfreeipmir/copyright: no copyright message found >> usr/src/pkgdefs/SUNWfreeipmiu/copyright: no copyright message found >> >> Doing CDDL block check: >> Warning: No CDDL block in file usr/src/cmd/freeipmi/METADATA >> Warning: No CDDL block in file >> usr/src/cmd/freeipmi/freeipmi-0.7.7.tar.gz >> Warning: No CDDL block in file usr/src/cmd/freeipmi/sunman-stability >> Warning: No CDDL block in file usr/src/pkgdefs/SUNWfreeipmir/copyright >> Warning: No CDDL block in file usr/src/pkgdefs/SUNWfreeipmiu/copyright >> >> Doing keywords check: >> Missing keywords in usr/src/cmd/freeipmi/METADATA >> Missing keywords in usr/src/cmd/freeipmi/freeipmi-0.7.7.tar.gz >> Missing keywords in usr/src/cmd/freeipmi/sunman-stability >> Missing keywords in usr/src/pkgdefs/SUNWfreeipmir/copyright >> Missing keywords in usr/src/pkgdefs/SUNWfreeipmiu/copyright >> >> Doing sccs rmdel check: >> >> Doing multi delta check: >> >> Doing comments check: >> >> Doing RTI check: >> Error: RTI 334428 for CR 6863639 is not in the accepted state. >> >> Doing out check: >> > wx pb -n >> putback: User jf222792 does not have access to putback to workspace >> "/ws/sfwnv-clone" (Warning 2065) >> Parent workspace: /ws/sfwnv-clone >> Child workspace: /builds4/jf222792/sfwnv_p >> >> Examined files: 28 >> >> Would put back contents changes: 28 >> >> update: usr/src/Targetdirs >> update: usr/src/cmd/Makefile >> update: usr/src/pkgdefs/Makefile >> create: usr/src/cmd/freeipmi/METADATA >> create: usr/src/cmd/freeipmi/Makefile.sfw >> create: usr/src/cmd/freeipmi/bmc-watchdog.xml >> create: usr/src/cmd/freeipmi/freeipmi-0.7.7.tar.gz >> create: usr/src/cmd/freeipmi/install-sfw >> create: usr/src/cmd/freeipmi/ipmidetectd.xml >> create: usr/src/cmd/freeipmi/man-fix >> create: usr/src/cmd/freeipmi/man-fix-sed >> create: usr/src/cmd/freeipmi/sunman-stability >> create: usr/src/cmd/freeipmi/svc-bmc-watchdog >> create: usr/src/cmd/freeipmi/svc-ipmidetectd >> create: usr/src/pkgdefs/SUNWfreeipmir/Makefile >> create: usr/src/pkgdefs/SUNWfreeipmir/copyright >> create: usr/src/pkgdefs/SUNWfreeipmir/depend >> create: usr/src/pkgdefs/SUNWfreeipmir/pkginfo.tmpl >> create: usr/src/pkgdefs/SUNWfreeipmir/prototype_com >> create: usr/src/pkgdefs/SUNWfreeipmir/prototype_i386 >> create: usr/src/pkgdefs/SUNWfreeipmir/prototype_sparc >> create: usr/src/pkgdefs/SUNWfreeipmiu/Makefile >> create: usr/src/pkgdefs/SUNWfreeipmiu/copyright >> create: usr/src/pkgdefs/SUNWfreeipmiu/depend >> create: usr/src/pkgdefs/SUNWfreeipmiu/pkginfo.tmpl >> create: usr/src/pkgdefs/SUNWfreeipmiu/prototype_com >> create: usr/src/pkgdefs/SUNWfreeipmiu/prototype_i386 >> create: usr/src/pkgdefs/SUNWfreeipmiu/prototype_sparc >> >> Examined files: 28 >> >> Contents Summary: >> 25 create >> 3 update >> 6 differentiate child >> >> No changes were put back >> > >> >> On 07/24/09 12:57, Amanda Waite wrote: >>> Jan Forch wrote: >>>> Hi, >>>> thanks a lot for hints. Files should be ok now. Amanda, could you >>>> check pbchk and pb -n outputs please? What about CR commnents? >>>> There is still one warning despite of format of comments is <CR #> >>>> <CR Synopsis>. Thank you >>> The comment should be: >>> >>> 6863639 Integrate freeipmi package into Solaris >>> >>> It's probably better that you add the CDDL header, copyright and >>> ident string to usr/src/cmd/freeipmi/man-fix-sed even though it's a >>> simple file. >>> >>> I also realised that usr/src/pkgdefs/SUNWfreeipmir/copyright and >>> usr/src/pkgdefs/SUNWfreeipmiu/copyright didn't appear in your webrev >>> so I've not reviewed them. Once you are done can you repost the webrev. >>> >>> For the putback, I'm not sure what this means: >>> >>> >> 6 differentiate child >>> >>> I think it's ok but maybe someone else can explain what this means. >>> >>> Thanks >>> >>> Amanda >> >
