Hi Karol, Please see my comments below.
1. usr/src/cmd/pciutils/Makefile.sfw Instead of writing your own unpack, patch rules, you'd better use the rules provided by sfw. Here is a good example. http://cr.opensolaris.org/~jwalker/meld/usr/src/cmd/meld/Makefile.sfw.html 2. usr/src/cmd/pciutils/Makefile.sfw Which compiler do you want to use? I think Sun Studio is the preferred one. Please use env - instead of env. 3. usr/src/cmd/pciutils/install-sfw You should use M instead of N to install man page. 4. usr/src/pkgdefs/SUNWiperf/depend It seems that you use the default depend file. But I think it is not enough. I wrote a small script to check the dependencies for C program. Here is an example, # ./depend.sh src/iperf /lib/libsocket.so.1 /lib/libnsl.so.1 /usr/sfw/lib/libstdc++.so.6 /lib/libm.so.2 /usr/lib/libgcc_s.so.1 /lib/libc.so.1 /lib/libmp.so.2 /lib/libmd.so.1 /lib/libscf.so.1 /lib/libuutil.so.1 /lib/libgen.so.1 P FSWfsmisc Miscellaneous filesystem support for OpenSolaris P SUNWcslr Core Solaris Libraries (Root) P SUNWgccruntime GCC Runtime libraries P SUNWlibmsr Math & Microtasking Libraries (Root) 5. The style of CDDL and copyright headers can be improved. Thanks, Chris karol wrote: > Hi All, > > I'm working on porting package "iperf" to opensolaris, which is for > measuring max TCP/UDP bandwidth performance. > > Could you help to review it? > > http://cr.opensolaris.org/~lxin/iperf/ > > Thanks, > Karol > _______________________________________________ > sfwnv-discuss mailing list > sfwnv-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss > -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: depend.sh URL: <http://mail.opensolaris.org/pipermail/sfwnv-discuss/attachments/20090209/58d2a1c3/attachment.ksh>
