Hi Karol,
Below are few comments
1. SOURCE field is missing in the METADATA file.please follow the rules
specified in the link below :
http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines
2. In Makefile.sfw,
- please use "env -" instead of "env" throughout.
- you could call configure as "$(SHELL) ./configure" so that there
will be predictability of which shell will be called.
- Also it appears that you are patching the source base after doing
a configure. It should generally be other way round. i.e untar the
tarball, patch it, run configure and then do a make
3. In install-sfw,
- In line 43, man page shouldn't be installed as a normal file.
Instead please use 'M' (as shown below) so that the sunman-stability
gets appended to the manpage.
_install *M* ${PKGDIR}/man/iperf.1 ${MAN1DIR}/iperf.1 444
4. iperf-2.0.4-pthreads-rt.patch
- Since Makefile gets generated during configure, any changes to it
should be made into Makefile.in/Makefile.am.
- Again, you shouldn't be editing "config.h" file which gets
generated after doing a configure. Instead patch "config..h.in" file.
5. In depend file,
- Please move the Copyright lines after the CDDL HEADER END.
- you could use the default depend file here if there are no project
specific dependencies. Please check.
6. In pkginfo.tmpl, you could add the version in the DESC field as below
DESC="iperf - tool for measuring maximum TCP and UDP bandwidth
performance. *(2.0.4)*"
Thanks,
Srirama
karol said the following on Monday 09 February 2009 11:58 AM:
> Hi All,
>
> I'm working on porting package "iperf" to opensolaris, which is for
> measuring max TCP/UDP bandwidth performance.
>
> Could you help to review it?
>
> http://cr.opensolaris.org/~lxin/iperf/
>
> Thanks,
> Karol
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://mail.opensolaris.org/pipermail/sfwnv-discuss/attachments/20090209/43e98849/attachment.html>
